-
-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Margin and padding issues which change suddenly when do dark mode #207
Comments
Can you elaborate more on how the fonts could changed on dark mode in the second case? |
In light mode, the font-size was fixed (px). But when in dark mode, the font-size becomes rem. Anyway, the fonts could change only in mobile view (perhaps because my front-end was config his own CSS). But this problem was solved by my front-end in our repository by overriding rem with px xD. |
In other words, in my case the problem was solved. But still in the most case, like the search input in simple datatable, the margin/padding would change suddenly when do dark mode. |
My mistake. The margin/padding bug in simple datatable was solved. I should have checked on branch vite not in the production D: |
Sometimes I experience weirdness when I'm in dark mode, which the margin/padding changing suddenly (not in accordance with light mode).
For example, in the search input of the datatable:
When the dark mode clicked, then:
In my case:
Light mode is fine.
But in dark mode, some designs are ruined.
The text was updated successfully, but these errors were encountered: