Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Margin and padding issues which change suddenly when do dark mode #207

Closed
Tracked by #209
alfianchii opened this issue Mar 26, 2023 · 4 comments
Closed
Tracked by #209

Comments

@alfianchii
Copy link
Collaborator

Sometimes I experience weirdness when I'm in dark mode, which the margin/padding changing suddenly (not in accordance with light mode).

For example, in the search input of the datatable:
image

When the dark mode clicked, then:
image

In my case:
Light mode is fine.
image

But in dark mode, some designs are ruined.
image

@zuramai zuramai mentioned this issue Mar 28, 2023
9 tasks
@zuramai
Copy link
Owner

zuramai commented Mar 29, 2023

Can you elaborate more on how the fonts could changed on dark mode in the second case?

zuramai added a commit that referenced this issue Mar 29, 2023
@alfianchii
Copy link
Collaborator Author

In light mode, the font-size was fixed (px). But when in dark mode, the font-size becomes rem. Anyway, the fonts could change only in mobile view (perhaps because my front-end was config his own CSS).

image
image

But this problem was solved by my front-end in our repository by overriding rem with px xD.

@alfianchii
Copy link
Collaborator Author

In other words, in my case the problem was solved. But still in the most case, like the search input in simple datatable, the margin/padding would change suddenly when do dark mode.

@alfianchii
Copy link
Collaborator Author

In other words, in my case the problem was solved. But still in the most case, like the search input in simple datatable, the margin/padding would change suddenly when do dark mode.

My mistake. The margin/padding bug in simple datatable was solved. I should have checked on branch vite not in the production D:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants