Owo news sources when URLs are unavailable #428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1716
💛 - Coveralls |
|
cc @zuzak for review and/or feedback |
zuzak
requested changes
Mar 19, 2021
There was a problem hiding this comment.
Hi Gaurav. Sorry for taking so long to get to this pull request. I don't want to merge it as-is, because this will add affixes to the source, which make it less likely to fit into a tweet as well as looking odd. For example:
New variety of cabbage set to revolutionize eating habits
― Reuters
at the moment becomes
OWO New vawiety of cabbage set to wevowutionise ouw eating habits (｀へ´)
― OWO Weutews (இωஇ )
whereas it should be something like
OWO New vawiety of cabbage set to wevowutionise ouw eating habits (｀へ´)
― Weutews
The best way to fix this is probably to use the owo.translate() function we added upstream instead of straight owo().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #419
Seeking reviews and comments.