fix: auto-fallback to no supervision for start/stopLevelChange #1178

AlCalzone · 2020-12-01T16:33:09Z

In #648 we changed start/stopLevelChange to use Supervision if it is supported. However this seems to cause problems with some devices.

With this PR we try a supervised command first. If that yields "No support", we remember that and fall back to an unsupervised command.

Side note: it might make sense to generalize this approach.

AlCalzone · 2020-12-01T16:33:49Z

@robertsLando @ODINServ this might fix the issue in zwave-js/zwave-js-ui#40 (review) - wanna give it a try?

robertsLando · 2020-12-01T16:35:14Z

@ODINServ You should use the zwavejs2mqtt master with this branch of zwavejs

ODINServ · 2020-12-01T16:37:05Z

Alright I don't have more time now, I'll try tomorrow

robertsLando · 2020-12-01T16:37:21Z

packages/zwave-js/src/lib/commandclass/MultilevelSwitchCC.ts

@@ -98,6 +99,14 @@ function getCurrentValueValueID(endpoint: number): ValueID {
 	};
 }

+/** Returns the ValueID used to remember whether a node supports supervision on the start/stop level change commands*/
+export function getSuperviseStartStopLevelChangeValueId(): ValueID {


@AlCalzone Is this internal right?

@AlCalzone I mean the valueId will not be crated right? It's an internal valueid? Does it need @internal ?

This is one of the weirder parts of value IDs. The function won't be exported now. The valueID is marked internal in the CC constructor (registerValue, boolean parameter). One of the many aspects to be considered in #552

Not 100% clear to me but ok I trust you 😆

robertsLando

LGTM

AlCalzone · 2020-12-01T17:21:37Z

Ok I'll wait for @ODINServ's test and then merge if it works.

ODINServ · 2020-12-02T08:54:41Z

Ok I'll wait for @ODINServ's test and then merge if it works.

Hey,
I think i am doing something wrong it cannot find the module:

Here is what i did:
@mqtt

git checkout master
git pull
npm install
npm run build

@node-zwave-js

git checkout master
git pull
git checkout startstoplevelchange-test-supervision
npm install
npm run build
cd packages/zwave-js
npm link

(( No errors ))

@mqtt

npm link zwave-js
(( output ))

$ npm link zwave-js

up to date, audited 2471 packages in 3s

1 package is looking for funding
  run `npm fund` for details

found 0 vulnerabilities

npm start

npm start

> zwavejs2mqtt@0.0.0 start
> node bin/www

Error: Cannot find module '@zwave-js/core'
Require stack:
- /home/user/zwave/zwavejs2mqtt/lib/ZwaveClient.js
- /home/user/zwave/zwavejs2mqtt/node_modules/app-root-path/lib/app-root-path.js
- /home/user/zwave/zwavejs2mqtt/node_modules/app-root-path/index.js
- /home/user/zwave/zwavejs2mqtt/bin/www
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:919:15)
    at Function.Module._load (node:internal/modules/cjs/loader:763:27)
    at Module.require (node:internal/modules/cjs/loader:991:19)
    at require (node:internal/modules/cjs/helpers:92:18)
    at Object.<anonymous> (/home/user/zwave/zwavejs2mqtt/lib/ZwaveClient.js:12:44)
    at Module._compile (node:internal/modules/cjs/loader:1102:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1131:10)
    at Module.load (node:internal/modules/cjs/loader:967:32)
    at Function.Module._load (node:internal/modules/cjs/loader:807:14)
    at Module.require (node:internal/modules/cjs/loader:991:19)
    at require (node:internal/modules/cjs/helpers:92:18)
    at require (/home/user/zwave/zwavejs2mqtt/node_modules/app-root-path/lib/app-root-path.js:14:11)
    at Object.<anonymous> (/home/user/zwave/zwavejs2mqtt/app.js:10:21)
    at Module._compile (node:internal/modules/cjs/loader:1102:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1131:10)
    at Module.load (node:internal/modules/cjs/loader:967:32) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/user/zwave/zwavejs2mqtt/lib/ZwaveClient.js',
    '/home/user/zwave/zwavejs2mqtt/node_modules/app-root-path/lib/app-root-path.js',
    '/home/user/zwave/zwavejs2mqtt/node_modules/app-root-path/index.js',
    '/home/user/zwave/zwavejs2mqtt/bin/www'
  ]
}

Any clues ? i can revert to a snapshot of my vm and get it working but what am i doing wrong ?

robertsLando · 2020-12-02T08:56:27Z

Try to run : npx lerna exec -- npm link instead of npm link in zwave-js repo

zwave-js is using workspaces that is only supported by npm@7, but I saw that npm link seems is't working well so the lerna way should work (it's like running npm link for each subfolder of packages folder)

ODINServ · 2020-12-02T09:04:20Z

$npm --version
7.0.14

@zwave-js

npx lerna exec -- npm link
results in lots of permission denied

So is did sudo npx lerna exec -- sudo npm link

But then:

[user@user-kvm zwavejs2mqtt]$ sudo npm link

added 1 package, and audited 2 packages in 449ms

found 0 vulnerabilities
[user@user-kvm zwavejs2mqtt]$ npm start

> zwavejs2mqtt@0.0.0 start
> node bin/www

Error: Cannot find module '@zwave-js/core'
Require stack:
- /home/user/zwave/zwavejs2mqtt/lib/ZwaveClient.js
- /home/user/zwave/zwavejs2mqtt/node_modules/app-root-path/lib/app-root-path.js
- /home/user/zwave/zwavejs2mqtt/node_modules/app-root-path/index.js
- /home/user/zwave/zwavejs2mqtt/bin/www
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:919:15)
    at Function.Module._load (node:internal/modules/cjs/loader:763:27)
    at Module.require (node:internal/modules/cjs/loader:991:19)
    at require (node:internal/modules/cjs/helpers:92:18)
    at Object.<anonymous> (/home/user/zwave/zwavejs2mqtt/lib/ZwaveClient.js:12:44)
    at Module._compile (node:internal/modules/cjs/loader:1102:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1131:10)
    at Module.load (node:internal/modules/cjs/loader:967:32)
    at Function.Module._load (node:internal/modules/cjs/loader:807:14)
    at Module.require (node:internal/modules/cjs/loader:991:19)
    at require (node:internal/modules/cjs/helpers:92:18)
    at require (/home/user/zwave/zwavejs2mqtt/node_modules/app-root-path/lib/app-root-path.js:14:11)
    at Object.<anonymous> (/home/user/zwave/zwavejs2mqtt/app.js:10:21)
    at Module._compile (node:internal/modules/cjs/loader:1102:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1131:10)
    at Module.load (node:internal/modules/cjs/loader:967:32) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/user/zwave/zwavejs2mqtt/lib/ZwaveClient.js',
    '/home/user/zwave/zwavejs2mqtt/node_modules/app-root-path/lib/app-root-path.js',
    '/home/user/zwave/zwavejs2mqtt/node_modules/app-root-path/index.js',
    '/home/user/zwave/zwavejs2mqtt/bin/www'
  ]
}

robertsLando · 2020-12-02T09:06:22Z

@ODINServ npm link that must be npm link zwave-js when running on zwavejs2mqtt folder

Zwavejs:

npx lerna exec -- npm link

Zwavejs2mqtt:

npm link zwave-js
npm link @zwave-js/core

AlCalzone · 2020-12-02T09:08:13Z

Error: Cannot find module '@zwave-js/core'

@robertsLando doesn't @ODINServ also have to npm link @zwave-js/core in the zwavejs2mqtt repo?

robertsLando · 2020-12-02T09:08:36Z

@AlCalzone Yes I have edited my comment

ODINServ · 2020-12-02T09:09:36Z

That was it indeed :) but now my break is over, doing the actual test at lunch time.

robertsLando · 2020-12-02T09:11:29Z

@AlCalzone IMO npm link should link all workspaces but seems it's not.

AlCalzone · 2020-12-02T09:15:20Z

IMO npm link should link all workspaces but seems it's not.

I'll need to do some more testing with that. Judging from the command description, it should indeed.

ODINServ · 2020-12-02T09:17:31Z

That was it indeed :) but now my break is over, doing the actual test at lunch time.

Well, that failed.

It still works! 💪 😄

Logs: zwave-js/zwave-js-ui#30 (comment)

robertsLando · 2020-12-02T09:22:19Z

Ok I think we can merge this now @AlCalzone :)

AlCalzone · 2020-12-02T09:36:17Z

perfect!

fix: auto-fallback to no supervision for start/stopLevelChange

19e2766

AlCalzone requested a review from robertsLando December 1, 2020 16:33

AlCalzone self-assigned this Dec 1, 2020

robertsLando reviewed Dec 1, 2020

View reviewed changes

refactor: don't export

40d0c35

AlCalzone requested a review from robertsLando December 1, 2020 17:03

robertsLando approved these changes Dec 1, 2020

View reviewed changes

AlCalzone merged commit 6ddf3bc into master Dec 2, 2020

AlCalzone deleted the startstoplevelchange-test-supervision branch December 2, 2020 09:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: auto-fallback to no supervision for start/stopLevelChange #1178

fix: auto-fallback to no supervision for start/stopLevelChange #1178

AlCalzone commented Dec 1, 2020

AlCalzone commented Dec 1, 2020

robertsLando commented Dec 1, 2020

ODINServ commented Dec 1, 2020

robertsLando Dec 1, 2020

AlCalzone Dec 1, 2020

robertsLando Dec 1, 2020

AlCalzone Dec 1, 2020

robertsLando Dec 1, 2020

robertsLando left a comment

AlCalzone commented Dec 1, 2020

ODINServ commented Dec 2, 2020

robertsLando commented Dec 2, 2020 •

edited

Loading

ODINServ commented Dec 2, 2020 •

edited

Loading

robertsLando commented Dec 2, 2020 •

edited

Loading

AlCalzone commented Dec 2, 2020

robertsLando commented Dec 2, 2020

ODINServ commented Dec 2, 2020

robertsLando commented Dec 2, 2020

AlCalzone commented Dec 2, 2020

ODINServ commented Dec 2, 2020 •

edited

Loading

robertsLando commented Dec 2, 2020

AlCalzone commented Dec 2, 2020

fix: auto-fallback to no supervision for start/stopLevelChange #1178

fix: auto-fallback to no supervision for start/stopLevelChange #1178

Conversation

AlCalzone commented Dec 1, 2020

AlCalzone commented Dec 1, 2020

robertsLando commented Dec 1, 2020

ODINServ commented Dec 1, 2020

robertsLando Dec 1, 2020

Choose a reason for hiding this comment

AlCalzone Dec 1, 2020

Choose a reason for hiding this comment

robertsLando Dec 1, 2020

Choose a reason for hiding this comment

AlCalzone Dec 1, 2020

Choose a reason for hiding this comment

robertsLando Dec 1, 2020

Choose a reason for hiding this comment

robertsLando left a comment

Choose a reason for hiding this comment

AlCalzone commented Dec 1, 2020

ODINServ commented Dec 2, 2020

robertsLando commented Dec 2, 2020 • edited Loading

ODINServ commented Dec 2, 2020 • edited Loading

robertsLando commented Dec 2, 2020 • edited Loading

AlCalzone commented Dec 2, 2020

robertsLando commented Dec 2, 2020

ODINServ commented Dec 2, 2020

robertsLando commented Dec 2, 2020

AlCalzone commented Dec 2, 2020

ODINServ commented Dec 2, 2020 • edited Loading

robertsLando commented Dec 2, 2020

AlCalzone commented Dec 2, 2020

robertsLando commented Dec 2, 2020 •

edited

Loading

ODINServ commented Dec 2, 2020 •

edited

Loading

robertsLando commented Dec 2, 2020 •

edited

Loading

ODINServ commented Dec 2, 2020 •

edited

Loading