Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conf): Add assoc. groups to Namron 2 kanaler bryter #2382

Closed
wants to merge 1 commit into from

Conversation

jmgiaever
Copy link

@jmgiaever jmgiaever commented Apr 16, 2021

Added the missing association groups for this device.

  1. https://www.elektroimportoren.no/docs/lib/4512720-Brukerveiledning-5.pdf
    See page 2 for groups.

Added the missing association groups for this device.
@zwave-js-assistant zwave-js-assistant bot added the config ⚙ Configuration issues or updates label Apr 16, 2021
Copy link
Member

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is not necessary. The device supports Z-Wave Plus and Association Group Info CC, so this info can be discovered automatically. We do still specify the groups to improve bad labels, so it depends on how the associations are shown without this change. Can you share that?

@jmgiaever
Copy link
Author

Hi,

It's seems like you are correct. However, the reason I added it was because the assoc.groups list showed up empty yesterday when I added the switch. But now they're there!

I haven't re-interviewed the nodes, so why they didn't show up yesterday is a mystery to me.

@jmgiaever jmgiaever closed this Apr 17, 2021
@jmgiaever
Copy link
Author

Can add: Turned out it was zwavejs2mqtt that needed a fullpage refresh to get the list of associations populated. Just re-tried with another remote now.

@AlCalzone
Copy link
Member

Can you still share how the associations are discovered? Wonder if the labels are okay or if we need your change after all.

@jmgiaever
Copy link
Author

Can you elaborate? Attach the log from the inclusion process?

@AlCalzone
Copy link
Member

Just a Screenshot of the available association group should be fine

@jmgiaever
Copy link
Author

jmgiaever commented Apr 17, 2021

Screenshot from 2021-04-17 08-58-34
After inclusion ⬆️

Screenshot from 2021-04-17 11-38-43
After a page refresh 1 kanal ⬆️

Screenshot from 2021-04-17 11-36-52
After a page refresh 2 kanaler ⬆️

But looks like @robertsLando already pushed a PR for a fix. I'm testing it out asap and keep you posted. Thanks!

EDIT: Sorry, took screenshot of the wrong node. However this occurred for all of them. I have 3, 1 «1 kanal» and 2 «2 kanaler» remotes.

@jmgiaever
Copy link
Author

jmgiaever commented Apr 17, 2021

Just a quick notice though; Looks like the «product name» is in the «product code», and the product name is empty?

The codes should be

  1. kanal: 4512712
  2. kanaler: 4512720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config ⚙ Configuration issues or updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants