Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nvmedit): parsing of 6.6x and 6.7x NVMs, use 6.7x NVM parser for protocol 6.01 #7399

Merged
merged 2 commits into from
Nov 13, 2024
Merged

fix(nvmedit): parsing of 6.6x and 6.7x NVMs, use 6.7x NVM parser for protocol 6.01 #7399

merged 2 commits into from
Nov 13, 2024

Conversation

AlCalzone
Copy link
Member

fixes: #7385

@AlCalzone
Copy link
Member Author

@zwave-js-bot automerge

@zwave-js-bot zwave-js-bot enabled auto-merge (squash) November 13, 2024 10:01
@zwave-js-bot zwave-js-bot merged commit 7345678 into master Nov 13, 2024
23 checks passed
@zwave-js-bot zwave-js-bot deleted the nvm-fixes branch November 13, 2024 10:04
AlCalzone added a commit that referenced this pull request Nov 14, 2024
@AlCalzone
chore: release v14.3.3
cecd3b7 
### Bugfixes
* Fix parsing of some older 500 series NVM formats (#7399)
* Fixed an issue where `mock-server` would not start due to an incorrect module format (#7401)
* Fixed an issue where the auto-generated argument validation for CC API methods would not work correctly in some cases when `zwave-js` was bundled (#7403)

### Config file changes
* Add HomeSys HomeMech-2001/2 (#7400)
niemyjski
niemyjski reviewed Nov 14, 2024
View reviewed changes
Copy link

@niemyjski niemyjski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a good way to test this, to prevent regressions on future prs?

@AlCalzone
Copy link
Member Author

The nvmedit package has some NVM backups as fixtures. Adding NVM files with the corresponding protocol versions should do the trick. I didn't want to add the one from the linked issue though, as it has a different size than expected for unknown reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niemyjski niemyjski niemyjski left review comments

@zwave-js-bot zwave-js-bot zwave-js-bot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nvmedit package doesn't recognize backup made from EZZee 500 series controller
3 participants
@AlCalzone @niemyjski @zwave-js-bot