Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup and fix Zniffer event bug #1279

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Code cleanup and fix Zniffer event bug #1279

merged 4 commits into from
Sep 20, 2024

Conversation

raman325
Copy link
Collaborator

@raman325 raman325 commented Sep 19, 2024 •
edited
Loading

  • Made all message handlers implement the MessageHandler interface
  • Fixed the event type for a zniffer event

@raman325 raman325 changed the title Add commands to retrieve registries + misc Fix Zniffer event bug and code cleanup Sep 19, 2024
@raman325 raman325 changed the title Fix Zniffer event bug and code cleanup Code cleanup and fix Zniffer event bug Sep 19, 2024
AlCalzone
AlCalzone approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder though if MessageHandler should be an interface, not an abstract class, or are you planning to add implementations to the base class?

@raman325
Copy link
Collaborator Author

If an interface can describe methods then yes that makes sense. I think I originally added this because it fit my python mental model

@AlCalzone
Copy link
Member

Yep, you just have to say the class implements MrssageHandler

@raman325 raman325 merged commit c7b1e2e into master Sep 20, 2024
1 check passed
@raman325 raman325 deleted the registries branch September 20, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCalzone AlCalzone AlCalzone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raman325 @AlCalzone