Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Failed Nodes - Remove All should skip sleepy devices #983

Closed
steve28 opened this issue Mar 31, 2021 · 2 comments · Fixed by #988
Closed

[feat] Failed Nodes - Remove All should skip sleepy devices #983

steve28 opened this issue Mar 31, 2021 · 2 comments · Fixed by #988
Assignees
Labels
enhancement New feature or request

Comments

@steve28
Copy link

steve28 commented Mar 31, 2021

Is your feature request related to a problem? Please describe.
If using Failed Nodes - Remove All, the system will remove ALL sleeping nodes. This is non-intuitive and quite destructive. I would expect this command to only remove nodes which are already marked dead.

Describe the solution you'd like
The Failed Nodes - Remove All command should skip sleepy devices. I think it's ok to keep for the individual node level "Remove Failed Node" but for a network-wide operation it should skip a device that could be asleep.

Describe alternatives you've considered
A compromise could be to show a warning dialog that indicates any device that is currently asleep will be removed. However, this would mean this button is useless for anyone that has battery devices in their network.

Additional context
N/A

@steve28 steve28 added the enhancement New feature or request label Mar 31, 2021
@robertsLando
Copy link
Member

@AlCalzone Should also this be an option to add to removeFailed call? Like ignoreSleeping

@AlCalzone
Copy link
Member

Seems unnecessary. If you call removeFailed for a single node, it is very very likely that you want to do exactly that.
The mentioned call only exists in zwavejs2mqtt, so zwavejs2mqtt should make sure that all calls make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants