fix(mqtt-ad): revert setting state_class on central scene entities #3582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it is a number, it also often has no value at all, and Home Assistant can't deal with that properly, so leaving it as a string that can default to an empty string when it has no value is a better solution. Refs zwave-js#3570
Pull Request Test Coverage Report for Build 7787065064
💛 - Coveralls |
robertsLando
approved these changes
Feb 5, 2024
|
@kpine Could you also give me your 👍🏼 on this? |
|
Closed in favor of a full revert: #3583 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is a number, it also often has no value at all, and Home Assistant can't deal with that properly, so leaving it as a string that can default to an empty string when it has no value is a better solution.
Refs #3570