Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): prevent sending removeFailed to sleeping nodes in broadcast #988

Merged
merged 1 commit into from
Apr 1, 2021
Merged

fix(ui): prevent sending removeFailed to sleeping nodes in broadcast #988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/components/ControlPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,8 @@ export default {
action: 'removeFailedNode',
args: {
broadcast: true,
confirm: 'This action will remove all failed nodes'
confirm:
'This action will remove all failed nodes. ATTENTION: this will skip sleeping nodes to prevent unwanted behaviours'
}
}
],
Expand Down Expand Up @@ -304,8 +305,15 @@ export default {
}

if (broadcast) {
for (let i = 0; i < this.nodes.length; i++) {
const nodeid = this.nodes[i].id
let nodes = this.nodes

// ignore sleeping nodes in broadcast request. Fixes #983
if (action === 'removeFailedNode') {
nodes = nodes.filter(n => n.status !== 'Asleep')
}

for (let i = 0; i < nodes.length; i++) {
const nodeid = nodes[i].id
this.apiRequest(action, [nodeid])
}
} else {
Expand Down