-
-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Controller has no neighbours after updating to zwave-js 7.0.0 #2335
[bug] Controller has no neighbours after updating to zwave-js 7.0.0 #2335
Comments
I have a feeling that it could be related to the same problem we had with zwave-js/zwave-js-ui#739 . Could you also do a nodes dump? YOu can find it in advanced dialog, it exports all nodes as a json file |
I have seen that issue, but I thought that is based on the multiple controllers.
Of course: Thank you! |
@andras-tim This has been fixed on master now. If you are using docker simply use |
@robertsLando I tested the I attached a new bundle: |
@andras-tim Seems your stick have no neighborns, please try to send a heal action to it. cc @AlCalzone |
I tried to heal the network, restart the container, pull out the dongle then restart, but nothing was helped. |
Just to be sure - Can you try this?
|
And did you previously use this network with OZW or did you create it fresh in zwave-js? |
The master2 state was almost the same as https://github.com/zwave-js/zwavejs2mqtt/issues/1034#issuecomment-818756085, but I didn't restart the machine. But I'm going to do this. In January I moved from OZW to zwave-js, but ~1 months ago I excluded the whole network device-by-device, reset the dongle via zwave-js and included the whole stuff. I always stored the docker-compose file with the whole config dir in git, so I can easily switch, check: |
in 4 hours I'm going to do the steps of https://github.com/zwave-js/zwavejs2mqtt/issues/1034#issuecomment-818756085 . |
If you can easily revert, then I'd be interested in another heal log from 2.4.1. From what I've seen, your stick immediately responds to the commands that tell it to update the nodes' neighbors with "cannot do that". I can't imagine that the zwave-js version has anything to do with that. |
Anything new? |
Sorry, I had personal issues. I'm going to reply this weekend. |
This issue has not seen any recent activity and was marked as "stale 💤". Feel free to reopen if the issue persists. |
@AlCalzone using the @dkmcgowan suggestion, these are the logs I generated at silly. Hope this helps and hopefully the .json file change took. |
Wow! It works now... 🙂
Maybe helpsWhat I tried before, w/o success?
What I tried only now?
If the restart was missing for the success, I should say sorry! |
I just removed all devices on my controller and did a hard reset, then I restart container, and then added one device back, but still no neighbors on the controller. I then removed the line mentioned above and captured the log, but don't see the full interview start 2021-05-04T23:08:59.509Z DRIVER ███████╗ ██╗ ██╗ █████╗ ██╗ ██╗ ███████╗ ██╗ ███████╗ |
I reset the device again, rebooted the machine, unplugged it from the extension cable and directly into the USB port, tried other USB ports, nothing makes the neighbors show up for the controller for me so far |
ok, after the hard reset the home id had changed, so I removed the interviewstage again, restart the container, and it came up, did the full interview again, and neighbors are there now |
@dkmcgowan could you define hard reset? |
in the zwavejs control panel, on the main page, click advanced, there is a "hard reset" option, it will remove all your devices... I removed all my nodes first to make them easier to add later, then did the hard reset... I don't know if that is what did it, changing the usb port, the cable, rebooting, or doing the interview remove from config again |
I still think there is an issue, the neighbors list is not updating... I added the controller and then 1 powered device, I got neighbors list on both of those, they knew about each other. I then added a second powered device, it came back and new about both the controller and the first device, but the controller and first device did not update their neighbors list. I tried multiple heal networks and they still did not. I added a 3rd and the process repeated itself |
I removed the interviewStage: Completed line again and it updated all the neighbors "nodes": { I'm more curious if it's an actual issue with routing or just all the data isn't coming back for some reason, but the network is working correcly |
btw, when I removed that one line on node 1, aka the controller, it updated the neighbors on not just the controller, but also all the nodes |
That's more likely and Compounded by the fact that the neighbors of devices are no longer re-queried after the very first interview. In fact retrieving the neighbor list basically just means "Hey controller, what are your known neighbors of node XYZ"?
It shouldn't, but 🤷🏻♂️ |
I think the controller is fine now and all I think is happening is zwavejs doesn't get the node neighbors list unless I remove that interview line and restart to do a full interview, then all the nodes update their neighbors in zwavejs, not on the devices themselves... I added another node, it had neighbors correct, all other nodes and controller did not, I unplugged controller and plugged into a PC and looked at it with zwave pc controller from silabs, it was all fine, all neighbors were correct, plugged back into zwavejs, removed line, did a full interview, all the neighbors showed up |
Heh, we should probably refresh these lists after adding a node. |
great, I think that will help, at least with people trying to visualize their network and see how to best move devices around, could possibly also give an advanced feature in the control panel to update neighbors information to force a full interview on the nodes, thanks! |
#2559 will fix this by adding a method that returns the up to date list of neighbors for each node instead of relying on stale cached data. zwavejs2mqtt will need to add support for this too. |
For those, like me, stumbling across the internet trying to find out why their controller shows no neighbors either in the network graph OR in the debug screen under the controller node when using a combined zwaveJS integration with zwavejs2mqtt control panel: https://github.com/zwave-js/zwavejs2mqtt/issues/739 I used the discussion above. Clearing browser cache seems to fix this problem. Unknown why the debug screen of the node shows no neighbors until a cache clear but I'll take it at face value for now. |
I don't store any node info in localstorage or cache, this is really weird and I will investigate into this |
Keep it monitored and tell me if this happens again |
Version
Checklist:
Build/Run method
zwavejs2mqtt: 3.2.0
zwave-js: 7.1.1
but the bug cames with:
zwavejs2mqtt: 3.0.0
zwave-js: 7.0.0
Describe the bug
(took on v3.0.0)
To Reproduce
Steps to reproduce the behavior:
1 Upgrade from v2.4.1 (0a723f9) to v3.0.0 (b48c1f7)
Expected behavior
(took on v2.4.1)
Additional context
In general, I use HA, but when I add/remove node I always turn off that to avoid unwanted states/nodes... e.g. when I add a new node, I always rename that, but the HA remembers the original ids...
zwavejs2mqtt.log
zwavejs_1.log
The text was updated successfully, but these errors were encountered: