Merge pull request #146 from mrexodia/nonfinal

Make Program and Assembler non-final
zyantific · Oct 13, 2024 · aa852f2 · aa852f2
2 parents 8de41a6 + c2c4ead
commit aa852f2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/zasm/include/zasm/program/program.hpp b/zasm/include/zasm/program/program.hpp
@@ -23,7 +23,7 @@ namespace zasm
 
     class Observer;
 
-    class Program final
+    class Program
     {
         std::unique_ptr<detail::ProgramState> _state;
 
@@ -39,11 +39,11 @@ namespace zasm
         /// Constructs an empty program with the specified machine mode.
         /// </summary>
         /// <param name="mode">Machine Mode</param>
-        Program(MachineMode mode);
+        explicit Program(MachineMode mode);
 
         Program(const Program&) = delete;
         Program(Program&& other) noexcept;
-        ~Program();
+        virtual ~Program();
 
         Program& operator=(const Program&) = delete;
         Program& operator=(Program&& other) noexcept;

diff --git a/zasm/include/zasm/x86/assembler.hpp b/zasm/include/zasm/x86/assembler.hpp
@@ -18,15 +18,15 @@ namespace zasm
 
 namespace zasm::x86
 {
-    class Assembler final : public Emitter<Assembler>, public Observer
+    class Assembler : public Emitter<Assembler>, public Observer
     {
         Program& _program;
         Node* _cursor{};
         InstrAttribs _attribState{};
 
     public:
-        Assembler(Program& _program);
-        ~Assembler();
+        explicit Assembler(Program& _program);
+        virtual ~Assembler();
 
         /// <summary>
         /// Sets the node at where the next node will be inserted after.