[Hub Generated] Review request for Microsoft.Advisor to add version s…

…table/2020-01-01 (Azure#8210) * add disabled property to digest config, change type of frequency property * fix examples * change bool to enum * add name property * apply prettier and fix frequency description
00Kai0 · Oct 12, 2020 · 87d286c · 87d286c
1 parent d851cd0
commit 87d286c
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 12 deletions.
diff --git a/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json b/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json
@@ -157,7 +157,9 @@
             "description": "Advisor configuration name. Value must be 'default'",
             "required": true,
             "type": "string",
-            "enum": ["default"],
+            "enum": [
+              "default"
+            ],
             "x-ms-enum": {
               "name": "ConfigurationName",
               "modelAsString": true
@@ -262,7 +264,9 @@
             "description": "Advisor configuration name. Value must be 'default'",
             "required": true,
             "type": "string",
-            "enum": ["default"],
+            "enum": [
+              "default"
+            ],
             "x-ms-enum": {
               "name": "ConfigurationName",
               "modelAsString": true
@@ -858,13 +862,18 @@
       "description": "Advisor Digest configuration entity",
       "type": "object",
       "properties": {
+        "name": {
+          "description": "Name of digest configuration. Value is case-insensitive and must be unique within a subscription.",
+          "type": "string"
+        },
         "actionGroupResourceId": {
           "description": "Action group resource id used by digest.",
           "type": "string"
         },
         "frequency": {
-          "description": "Frequency that digest will be triggered. Value must conform to ISO 8601 standard and must be greater than equal to 7 day and less than or equal to 30 days.",
-          "type": "string"
+          "format": "int32",
+          "description": "Frequency that digest will be triggered, in days. Value must be between 7 and 30 days inclusive.",
+          "type": "integer"
         },
         "categories": {
           "description": "Categories to send digest for. If categories are not provided, then digest will be sent for all categories.",
@@ -887,6 +896,18 @@
         "language": {
           "description": "Language for digest content body. Value must be ISO 639-1 code for one of Azure portal supported languages. Otherwise, it will be converted into one. Default value is English (en).",
           "type": "string"
+        },
+        "state": {
+          "description": "State of digest configuration.",
+          "enum": [
+            "Active",
+            "Disabled"
+          ],
+          "type": "string",
+          "x-ms-enum": {
+            "name": "DigestConfigState",
+            "modelAsString": true
+          }
         }
       }
     },

diff --git a/...or/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/CreateConfiguration.json b/...or/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/CreateConfiguration.json
@@ -9,16 +9,18 @@
         "exclude": true,
         "digests": [
           {
+            "name": "digestConfigName",
             "actionGroupResourceId": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/microsoft.insights/actionGroups/actionGroupName",
-            "frequency": "P30D",
+            "frequency": 30,
             "categories": [
               "HighAvailability",
               "Security",
               "Performance",
               "Cost",
               "OperationalExcellence"
             ],
-            "language": "en"
+            "language": "en",
+            "state": "Active"
           }
         ]
       }
@@ -36,20 +38,22 @@
           "exclude": true,
           "digests": [
             {
+              "name": "digestConfigName",
               "actionGroupResourceId": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/microsoft.insights/actionGroups/actionGroupName",
-              "frequency": "P30D",
+              "frequency": 30,
               "categories": [
                 "HighAvailability",
                 "Security",
                 "Performance",
                 "Cost",
                 "OperationalExcellence"
               ],
-              "language": "en"
+              "language": "en",
+              "state": "Active"
             }
           ]
         }
       }
     }
   }
-}
+}
diff --git a/...sor/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/ListConfigurations.json b/...sor/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/ListConfigurations.json
@@ -17,16 +17,18 @@
               "exclude": false,
               "digests": [
                 {
+                  "name": "digestConfigName",
                   "actionGroupResourceId": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/microsoft.insights/actionGroups/actionGroupName",
-                  "frequency": "P30D",
+                  "frequency": 30,
                   "categories": [
                     "HighAvailability",
                     "Security",
                     "Performance",
                     "Cost",
                     "OperationalExcellence"
                   ],
-                  "language": "en"
+                  "language": "en",
+                  "state": "Active"
                 }
               ]
             }
@@ -36,4 +38,4 @@
       }
     }
   }
-}
+}