Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 #8210

Merged
merged 5 commits into from
Jan 31, 2020
Merged

[Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 #8210

merged 5 commits into from
Jan 31, 2020

Conversation

parkhyukjun89
Copy link
Contributor

@parkhyukjun89 parkhyukjun89 commented Jan 23, 2020 •
edited
Loading

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@parkhyukjun89
Copy link
Contributor Author

We did not update our ARM manifest yet to enable this api-version (2020-01-01) and no public document changes were made yet (it's still pointing to old api-version (2017-04-19, https://docs.microsoft.com/en-us/rest/api/advisor/configurations)). So, I thought it'd be okay to make some breaking changes to the same api-version.

@allenjzhang allenjzhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 23, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

2 similar comments
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 27, 2020 •
edited
Loading

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from e6c7e08 with merge commit b7fd3b3. SDK Automation 13.0.17.20191226.1
  • ⚠️advisor/mgmt/2017-03-31 [Logs]  
      No file is changed.
    • ⚠️advisor/mgmt/2017-04-19 [Logs]  
        No file is changed.
      • ⚠️preview/advisor/mgmt/2016-07-12-preview [Logs]  
          No file is changed.

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Jan 27, 2020 •
        edited
        Loading

        azure-sdk-for-net - Release

        ❌ failed [Logs] [Expand Details]
        • ❌ Generate from e6c7e08 with merge commit b7fd3b3. SDK Automation 13.0.17.20191226.1 
          [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
        • ❌Microsoft.Azure.Management.Advisor [Logs]  [Release SDK Changes] 
            Failed to create the package Microsoft.Azure.Management.Advisor.
Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=advisor /v:n /p:SkipTests=true , {}

          @openapi-sdkautomation
          Copy link

          openapi-sdkautomation bot commented Jan 27, 2020 •
          edited
          Loading

          azure-sdk-for-java - Release

          ️✔️ succeeded [Logs] [Expand Details]
          • ️✔️ Generate from e6c7e08 with merge commit b7fd3b3. SDK Automation 13.0.17.20191226.1 
            Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-java/pull/848: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 31 Jan 2020 17:23:58 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"04D6:3BC0:7CCCF2:12879CA:5E3462AC","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4953","x-ratelimit-reset":"1580495024","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-java/git/refs/heads/sdkAutomation/sdk_advisor_mgmt-v2017_03_31@8210","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.14.0 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
          • ️✔️sdk/advisor/mgmt-v2016_07_12_preview [Logs]  [Release SDK Changes]
          • ️✔️sdk/advisor/mgmt-v2017_03_31 [Logs]  [Release SDK Changes]
          • ️✔️sdk/advisor/mgmt-v2017_04_19 [Logs]  [Release SDK Changes]

          @openapi-sdkautomation
          Copy link

          openapi-sdkautomation bot commented Jan 27, 2020 •
          edited
          Loading

          azure-sdk-for-python - Release

          ️✔️ succeeded [Logs] [Expand Details]
          • ️✔️ Generate from e6c7e08 with merge commit b7fd3b3. SDK Automation 13.0.17.20191226.1
          • ️✔️azure-mgmt-advisor [Logs]  [Release SDK Changes] 
            [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

          @openapi-sdkautomation
          Copy link

          openapi-sdkautomation bot commented Jan 27, 2020 •
          edited
          Loading

          azure-sdk-for-js - Release

          ️✔️ succeeded [Logs] [Expand Details]
          • ️✔️ Generate from e6c7e08 with merge commit b7fd3b3. SDK Automation 13.0.17.20191226.1
          • ️✔️@azure/arm-advisor [Logs]  [Release SDK Changes] 
            [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/advisorManagementClient.js → ./dist/arm-advisor.js...
[npmPack] created ./dist/arm-advisor.js in 255ms

          This was referenced Jan 27, 2020
          Closed
          Closed
          Closed
          Closed
          Closed
          Closed
          Closed
          @parkhyukjun89
          Copy link
          Contributor Author

          @allenjzhang I addressed all issues you mentioned. Can you please review again?

          @anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 30, 2020
          @anthony-c-martin
          Copy link
          Member

          Approving - SDKs not published and manifest support has not yet been added, so I think we can waive the breaking-change rules for this case.

          @allenjzhang allenjzhang merged commit b7fd3b3 into Azure:master Jan 31, 2020
          ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
          @parkhyukjun89 @ssripadham
          [Hub Generated] Review request for Microsoft.Advisor to add version s…
          9c43445 
          …table/2020-01-01 (Azure#8210)

* add disabled property to digest config, change type of frequency property

* fix examples

* change bool to enum

* add name property

* apply prettier and fix frequency description
          00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
          @parkhyukjun89 @00Kai0
          [Hub Generated] Review request for Microsoft.Advisor to add version s…
          87d286c 
          …table/2020-01-01 (Azure#8210)

* add disabled property to digest config, change type of frequency property

* fix examples

* change bool to enum

* add name property

* apply prettier and fix frequency description
          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
          Reviewers

          @allenjzhang allenjzhang allenjzhang approved these changes

          Assignees

          @allenjzhang allenjzhang

          Labels
          ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
          Projects
          None yet
          Milestone
          No milestone
          Development

          Successfully merging this pull request may close these issues.
          3 participants
          @parkhyukjun89 @anthony-c-martin @allenjzhang