-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add timestamps to certificate #175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goran-ethernal
requested review from
vcastellm,
Stefan-Ethernal and
joanestebanr
November 8, 2024 12:39
goran-ethernal
changed the title
Feat/add timestamps to certificate
Feat: add timestamps to certificate
Nov 8, 2024
goran-ethernal
changed the title
Feat: add timestamps to certificate
feat: add timestamps to certificate
Nov 8, 2024
joanestebanr
approved these changes
Nov 8, 2024
goran-ethernal
force-pushed
the
feat/add_timestamps_to_certificate
branch
from
November 8, 2024 13:28
5597648
to
2274bd9
Compare
Stefan-Ethernal
approved these changes
Nov 8, 2024
Quality Gate passedIssues Measures |
Vui-Chee
added a commit
to okx/xlayer-cdk
that referenced
this pull request
Nov 20, 2024
* dev: (30 commits) Delete build rust bin file test: fix v0.4.0 beta10 fix ut (#6) fix: aggregating proofs (0xPolygon#191) feat: improve aggsender logs (0xPolygon#186) fix: ut fix: add new error feat: include aggsender to release 0.4.0 (0xPolygon#181) feat: remove sanity check (0xPolygon#178) feat: sync UpdateL1InfoTreeV2 (0xPolygon#145) fix: local configuration bumping kurtosis to 0.2.29 (0xPolygon#176) chore: bump kustoris (0xPolygon#168) feat: add timestamps to certificate (0xPolygon#175) fix: Various pessimistic proofs fixes and adaption to `kurtosis-cdk` pessimistic proof branch (0xPolygon#165) feat: align Develop with changes in Release/0.4.0 (0xPolygon#174) feat: sqlite reorgdetector (0xPolygon#160) feat: Use ListOffChainData instead of GetOffChainData (0xPolygon#152) bump versions Reapply "chore: bump cdk-erigon to v2.1.2" (0xPolygon#162) apply feedback hotfix: bad merge ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds three new fields to the
CertificateInfo
struct we save inaggsender
db
:created_at
- a timestamp that indicates when was the certificate created on theaggsender
.updated_at
- a timestamp that indicates when was the certificate last updated. For example, it moved from Pending to Candidate.signed_cerificated
- raw string of the certificate that we sent toagglayer
.All of these fields will be used for easier debugging and logging.