Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove sanity check #178

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

ToniRamirezM
Copy link
Contributor

@ToniRamirezM ToniRamirezM commented Nov 12, 2024

Description

Removes unneeded sanity check

@ToniRamirezM ToniRamirezM requested review from joanestebanr and a team November 12, 2024 10:11
@ToniRamirezM ToniRamirezM self-assigned this Nov 12, 2024
Copy link
Contributor

@joanestebanr joanestebanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sanity check is no longer required because the l1InfoRootIndex is comming from batchl2data and it's same place that is checked. The sanity sanityCheck goal was to check that the batch data comming from Data-stream was right

@ToniRamirezM ToniRamirezM merged commit b480dd4 into release/v0.4.0 Nov 12, 2024
10 checks passed
@ToniRamirezM ToniRamirezM deleted the feature/removeSanitycheck branch November 12, 2024 10:35
ToniRamirezM added a commit that referenced this pull request Nov 12, 2024
ToniRamirezM added a commit that referenced this pull request Nov 12, 2024
joanestebanr added a commit that referenced this pull request Nov 12, 2024
* feat: unpack and log agglayer errors (#158)

* feat: unpack and log agglayer errors

* feat: agglayer error unpacking

* fix: lint and UT

* feat: epoch notifier (#144)

- Send certificates after a percentage of epoch
- Require epoch configuration to AggLayer
- Change config of `aggsender` adding: `BlockFinality` and `EpochNotificationPercentage`

* refact: GetSequence method (#169)

* feat: remove sanity check (#178) (#179)

---------

Co-authored-by: Goran Rojovic <100121253+goran-ethernal@users.noreply.github.com>
Co-authored-by: Rachit Sonthalia <54906134+rachit77@users.noreply.github.com>
Co-authored-by: Toni Ramírez <58293609+ToniRamirezM@users.noreply.github.com>
Vui-Chee added a commit to okx/xlayer-cdk that referenced this pull request Nov 20, 2024
* dev: (30 commits)
  Delete build rust bin file
  test: fix v0.4.0 beta10 fix ut (#6)
  fix: aggregating proofs (0xPolygon#191)
  feat: improve aggsender logs (0xPolygon#186)
  fix: ut
  fix: add new error
  feat: include aggsender to release 0.4.0 (0xPolygon#181)
  feat: remove sanity check (0xPolygon#178)
  feat: sync UpdateL1InfoTreeV2 (0xPolygon#145)
  fix:  local configuration bumping kurtosis to 0.2.29 (0xPolygon#176)
  chore: bump kustoris (0xPolygon#168)
  feat: add timestamps to certificate (0xPolygon#175)
  fix: Various pessimistic proofs fixes and adaption to `kurtosis-cdk`  pessimistic proof branch (0xPolygon#165)
  feat: align Develop with changes in Release/0.4.0 (0xPolygon#174)
  feat: sqlite reorgdetector (0xPolygon#160)
  feat: Use ListOffChainData instead of GetOffChainData (0xPolygon#152)
  bump versions
  Reapply "chore: bump cdk-erigon to v2.1.2" (0xPolygon#162)
  apply feedback
  hotfix: bad merge
  ...
Vui-Chee added a commit to okx/xlayer-cdk that referenced this pull request Dec 3, 2024
* tag 'v0.5.0-beta6':
  feat: write on database the number of retries per certificate and the certificates in a history table (0xPolygon#208)
  feat: return an error in case agglayer returns certificate with height lower than in local storage (0xPolygon#209)
  chore: simplify the `HashMeddler` (0xPolygon#205)
  fix: clean proof table on start (0xPolygon#207) (0xPolygon#210)
  feat: improve logs (0xPolygon#204)
  fix: cdk603 error calculating previousLocalExitRoot (0xPolygon#199)
  fix: Integration Bali PP (0xPolygon#198)
  feat: check agglayer certificate and use as initial if db is empty (0xPolygon#192)
  feat: sqlite aggregator (0xPolygon#189)
  feat: BridgeMessage e2e test (0xPolygon#184)
  feat: aggsender e2e (0xPolygon#183)
  fix: aggregating proofs (0xPolygon#191) (0xPolygon#193)
  feat: l1infotreesync can be run as individual component (0xPolygon#188)
  fix: l1infotree flaky test (0xPolygon#182)
  fix: `L1InfoRootIncorrect` error from `agglayer` (0xPolygon#185)
  feat: improve aggsender logs (0xPolygon#186) (0xPolygon#187)
  feat: remove sanity check (0xPolygon#178) (0xPolygon#179)
  refact: GetSequence method (0xPolygon#169)
  feat: epoch notifier (0xPolygon#144)
  feat: unpack and log agglayer errors (0xPolygon#158)
Vui-Chee added a commit to okx/xlayer-cdk that referenced this pull request Dec 4, 2024
* dev: (22 commits)
  fix issues
  feat: healthcheck (#11)
  feat: write on database the number of retries per certificate and the certificates in a history table (0xPolygon#208)
  feat: return an error in case agglayer returns certificate with height lower than in local storage (0xPolygon#209)
  chore: simplify the `HashMeddler` (0xPolygon#205)
  fix: clean proof table on start (0xPolygon#207) (0xPolygon#210)
  feat: improve logs (0xPolygon#204)
  fix: cdk603 error calculating previousLocalExitRoot (0xPolygon#199)
  fix: Integration Bali PP (0xPolygon#198)
  feat: check agglayer certificate and use as initial if db is empty (0xPolygon#192)
  feat: sqlite aggregator (0xPolygon#189)
  feat: BridgeMessage e2e test (0xPolygon#184)
  feat: aggsender e2e (0xPolygon#183)
  fix: aggregating proofs (0xPolygon#191) (0xPolygon#193)
  feat: l1infotreesync can be run as individual component (0xPolygon#188)
  fix: l1infotree flaky test (0xPolygon#182)
  fix: `L1InfoRootIncorrect` error from `agglayer` (0xPolygon#185)
  feat: improve aggsender logs (0xPolygon#186) (0xPolygon#187)
  feat: remove sanity check (0xPolygon#178) (0xPolygon#179)
  refact: GetSequence method (0xPolygon#169)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants