Integrate go-ibft consensus engine to polybft consensus protocol #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* consensus runtime backend metohod (not buildable) * transport * polybft - run cycle * transport fix 2 * small changes * less complex ibft consennsus wrapper.Example: https://replit.com/@crewce/Newest#main.go * small changes * runSequence better * remove pbftTransportWrapper * noone likes temp variables * Comment fixed * jm fixes Co-authored-by: Igor Crevar <crewce@gmail.com>
* consensus runtime backend metohod (not buildable) * transport * polybft - run cycle * transport fix 2 * less complex ibft consennsus wrapper.Example: https://replit.com/@crewce/Newest#main.go * Implement MessageConstructor interface. * Tidy linter errors. * runSequence better * remove pbftTransportWrapper * Add quorum size implementation. * Remove one part of pbft.NodeID reference. * Add some comments. * IsValid, Build proposal on FSM * Add block validation. * Add stub for IsValidSender method. * Sender validation is always true. * fsm - Insert block * simplify build proposal * Tidy logs. * IsValidSender * pbft.Proposal removed * Tidy errors. * restartEpoch if epoch is nil, remove hook in fsm * initialization fix * Fix compare. * quorum fixes and error propagation * evm-151 changes + additional needed in this task * Increase test timeout. * bring back some part of fsm * just execute syn test 100 times in a row * Tidy part of errors. * Revert e2e test. * Remove unused code and move message creator interface implementation. * minor fix * Add comments. * code organization - valdateSender + recoverAddress * Fix compile after merge. * small change * restart epoch on better place. lastBuiltBlock and epoch should not be nil * small reorg in polybft * pr fix * Update comments * pr fixes no 2 * Add voting power to the validators (#880) * Add voting power to the validator account * Rename ValidatorAccount to ValidatorMetadata * Set voting power to the existing test * Comment fixes * Rename files * Address comments * Remove extra space from the comment * pr fixes * Rename GetValidatorAccount to GetValidatorMetadata Co-authored-by: Nemanja0x <nemanja@ethernal.tech> Co-authored-by: Igor Crevar <crewce@gmail.com> Co-authored-by: Stefan Negovanović <stefan@ethernal.tech> Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## feature/v3-parity #891 +/- ##
====================================================
Coverage ? 49.31%
====================================================
Files ? 161
Lines ? 21633
Branches ? 0
====================================================
Hits ? 10668
Misses ? 10113
Partials ? 852 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Stefan-Ethernal
force-pushed
the
go-ibft-integration
branch
from
2a890d0
to
5698205
Compare
* Populate round info and change proposal hash * Adopt currentRound from BuildProposal * Fix logs * Fix proposal hash calculation inside IsValidProposalHash * Update go-ibft version * Igor's feedback addressed
Stefan-Ethernal
assigned Stefan-Ethernal, Nemanja0x, igorcrevar and 0xSasaPrsic and unassigned Stefan-Ethernal
Stefan-Ethernal
changed the title
Stefan-Ethernal
requested review from
zivkovicmilos,
lazartravica,
Kourin1996,
dbrajovic,
0xAleksaOpacic and
ferranbt
as code owners
b00ris
approved these changes
Nov 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Placeholder PR for go-ibft integration feature, which integrates go-ibft consensus engine into polybft consensus protocol.
Changes include
Checklist
Testing