fix: clean up mediastream plugins #3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
KaustubhKumar05
commented
Sep 24, 2024
•
KaustubhKumar05
commented
- Test on mweb and desktop
KaustubhKumar05
requested review from
raviteja83,
eswarclynn and
amar-1995
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
raviteja83
reviewed
Sep 24, 2024
packages/hms-video-store/src/plugins/video/HMSMediaStreamPluginsManager.ts
Outdated
Show resolved
Hide resolved
packages/hms-video-store/src/media/tracks/HMSLocalVideoTrack.ts
Outdated
Show resolved
Hide resolved
raviteja83
previously approved these changes
Oct 8, 2024
amar-1995
reviewed
Oct 8, 2024
ygit
previously approved these changes
Oct 8, 2024
amar-1995
approved these changes
Oct 8, 2024
raviteja83
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.