Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up mediastream plugins #3287

Merged
merged 3 commits into from
Oct 8, 2024
Merged

fix: clean up mediastream plugins #3287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9cdc533
fix: clean up mediastream plugins
KaustubhKumar05 Sep 24, 2024
d5896a8
fix: cleanup order
KaustubhKumar05 Sep 24, 2024
8ef5451
fix: add comment to elaborate on cleanup order
KaustubhKumar05 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/hms-video-store/src/media/tracks/HMSLocalVideoTrack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,9 +261,11 @@ export class HMSLocalVideoTrack extends HMSVideoTrack {
*/
async cleanup() {
this.removeTrackEventListeners(this.nativeTrack);
// Stopping the plugin before cleaning the track is more predictable when dealing with 3rd party plugins
await this.mediaStreamPluginsManager.cleanup();
KaustubhKumar05 marked this conversation as resolved.
Show resolved Hide resolved
await this.pluginsManager.cleanup();
super.cleanup();
this.transceiver = undefined;
await this.pluginsManager.cleanup();
this.processedTrack?.stop();
this.isPublished = false;
if (isBrowser && isMobile()) {
Expand Down
4 changes: 4 additions & 0 deletions packages/hms-video-store/src/plugins/video/HMSMediaStreamPluginsManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,8 @@ export class HMSMediaStreamPluginsManager {
getPlugins(): string[] {
return Array.from(this.plugins).map(plugin => plugin.getName());
}

async cleanup() {
this.removePlugins(Array.from(this.plugins));
}
}
Loading