fix: correct voting count during disconnection #3396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hdz-666
changed the title
KaustubhKumar05
previously approved these changes
Dec 5, 2024
KaustubhKumar05
previously approved these changes
Dec 5, 2024
hdz-666
changed the title
hdz-666
changed the title
|
@hdz-666 in the current release, let's disable the Vote button when the network connection is unavailable. |
|
Closing this in favour of #3409 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ice Disconnection for peers result in irregular voting metrics
loom for reference => https://www.loom.com/share/bf8e93d025aa4c3faec335dc95a03af6?sid=5059f8be-06b4-4de1-9a09-af01762710c3
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
Implementation note, gotchas, related work and Future TODOs (optional)
Has two commits one to disable vote and reach android sdk level
secondly, to make handling even better for voting and place votes after reconnect.
Merging:
Issue
Loom for issue => https://www.loom.com/share/7867a1deefd14216a02f61bf1e3c03af?sid=d6c715ee-4c58-4e52-b7f7-429652db938b