Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable voting when disconnected #3409

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix: disable voting when disconnected #3409

merged 1 commit into from
Dec 10, 2024

Conversation

hdz-666
Copy link
Collaborator

@hdz-666 hdz-666 commented Dec 9, 2024 •
edited by ygit
Loading

Description

  • Mitigate correct voting count during disconnection

Pre-launch Checklist

  • The Documentation is updated accordingly, or this PR doesn't require it.
  • I updated/added relevant documentation.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Merging:

  • Squash merge to dev
  • Merge commit to publish-alpha and main

@vercel Vercel
Copy link

vercel bot commented Dec 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 10:06am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 10:06am

@ygit ygit mentioned this pull request Dec 9, 2024
Closed
@ygit ygit enabled auto-merge (squash) December 10, 2024 06:18
@ygit ygit changed the title Fix: Mitigate correct voting count during disconnection fix: Mitigate correct voting count during disconnection Dec 10, 2024
ygit
ygit approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@ygit ygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raviteja83 raviteja83 changed the title fix: Mitigate correct voting count during disconnection fix: disable voting when disconnected Dec 10, 2024
@ygit ygit merged commit cf530a0 into dev Dec 10, 2024
4 checks passed
@ygit ygit deleted the feat/ISS-30705-voting-while-disconnection-mitigation branch December 10, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygit ygit ygit approved these changes

@raviteja83 raviteja83 raviteja83 approved these changes

@KaustubhKumar05 KaustubhKumar05 Awaiting requested review from KaustubhKumar05

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hdz-666 @raviteja83 @ygit