[TECH] Faire échouer la CI sur le set recommended de eslint-mocha sur l'API. #3893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm deploying this PR to these urls:
Please check it out! |
octo-topi
changed the title
ajoanny
reviewed
Jan 3, 2022
| mocha/no-exclusive-tests: error | ||
| mocha/no-pending-tests: error | ||
| mocha/no-skipped-tests: error | ||
| mocha/no-top-level-hooks: error |
There was a problem hiding this comment.
Celui je sais pas trop dans le test helper il y a un after et un afterEach
There was a problem hiding this comment.
Effectivement, mais il vaut mieux dans ce cas mettre une exception dans le test helper
(l'exception qui veut dire: je suis conscient que c'est pas bien mais ici c'est ok)
ajoanny
approved these changes
Jan 3, 2022
aceol
approved these changes
Jan 4, 2022
| mocha/no-exclusive-tests: error | ||
| mocha/no-pending-tests: error | ||
| mocha/no-skipped-tests: error | ||
| mocha/no-top-level-hooks: error |
There was a problem hiding this comment.
Effectivement, mais il vaut mieux dans ce cas mettre une exception dans le test helper
(l'exception qui veut dire: je suis conscient que c'est pas bien mais ici c'est ok)
pix-service-auto-merge
force-pushed
the
tech-set-all-mocha-recommended-rules-as-mandatory
branch
from
37ff008 to
6e04212
Compare
pix-service-auto-merge
force-pushed
the
tech-set-all-mocha-recommended-rules-as-mandatory
branch
from
6e04212 to
d45978f
Compare
pix-service-auto-merge
deleted the
tech-set-all-mocha-recommended-rules-as-mandatory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Les règles
recommendedne causent pas toutes la sortie en erreur de la CI, voir la documentation, ce qui n'est pas évident à comprendre au premier abord.🎁 Solution
Forcer la sortie en erreur en passant le niveau de celles en
warningàerror🌟 Remarques
Cette PR étend la solution de la PR #3887
Il serait intéressant de la rajouter dans les autres utilisations de mocha (mon-pix) #3894
🎅 Pour tester
Ajouter un test en skip et vérifie que
npm run lintrenvoie un code retour <> 0