Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Alt周りの強化 #142

Merged
merged 11 commits into from
Aug 14, 2024
Merged

feat: Alt周りの強化 #142

merged 11 commits into from
Aug 14, 2024

Conversation

1673beta
Copy link
Owner

What

  • 画像がAPNGの場合GIFではなくAPNGと表示するように
  • 画像のタイトルには必ずファイル名を使用するように
  • ファイル名とALTを同時に表示するように
  • 隠すボタンを大きく
  • ALTテキストが存在する場合ファイルを輸入するように
  • ALTが設定されてない場合投稿フォームで警告を出すトグルオプションを追加

Why

close #141
close #138

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG_CHERRYPICK.md
  • (If possible) Add tests

@1673beta
Copy link
Owner Author

真夜中にプルリク出すと大抵碌なことがない

@1673beta
Copy link
Owner Author

todo: ファイルにaltが表示されてない場合にファイルに説明追加できるやつを出すようにする

@1673beta
Copy link
Owner Author

一旦closeして他のPRに分割した方がいい気がしてきた

@1673beta
Copy link
Owner Author

分割!!!!!分割!!!!!!!!changelog書いたら一旦おしまい!!!!!!!!!!

@1673beta
Copy link
Owner Author

doneとみなしてマージ

@1673beta 1673beta merged commit 10f8e04 into develop Aug 14, 2024
8 of 21 checks passed
@1673beta 1673beta deleted the alt branch August 14, 2024 08:18
noridev added a commit to kokonect-link/cherrypick that referenced this pull request Oct 3, 2024
  - 노트를 게시하기 전에 첨부한 파일에 캡션이 없으면 경고를 표시합니다.
  - 이 변경으로 이미지 뷰어의 파일 이름 영역에는 더 이상 캡션이 아닌 실제 파일 이름이 표시됩니다.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant