LG-14259 Update Report formatting #11166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Internal, Reporting, Update LG-99 Report Layout
MrNagoo
commented
Aug 29, 2024
| @@ -29,7 +29,7 @@ def perform(date = Time.zone.yesterday.end_of_day) | |||
|
|
|||
| ReportMailer.tables_report( | |||
| email: email_addresses, | |||
| subject: "Fraud Metrics Report - #{date.to_date}", | |||
| subject: "Fraud Metrics Report - #{report_date.to_date}", | |||
There was a problem hiding this comment.
using the accessor.
|
Can we please add some before/after screenshots to help add context to the changes? |
Comment on lines
53
to
-54
| def as_emailable_reports | ||
| Reporting::EmailableReport.new( |
There was a problem hiding this comment.
I'm glad this plural method name is now actually returning an array
|
Pics added. Thanks! |
zachmargolis
approved these changes
Aug 30, 2024
| ] | ||
| end | ||
|
|
||
| def to_csvs |
There was a problem hiding this comment.
this method is unused now, right? let's remove it entirely
| ] | ||
| end | ||
|
|
||
| def as_tables |
There was a problem hiding this comment.
ditto, this is unused too?
There was a problem hiding this comment.
yep, done. If we ever want to mimic some of the other reporting then we can just add it back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Internal, Reporting, Update LG-99 Report Layout
🎫 Ticket
Link to the relevant ticket:
LG-14259
🛠 Summary of changes
Broke the LG-99 csv/tables into 3 sections
LG-99
Suspension
Reinstatement
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screen Shots
Before:
After:
