-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy RC 411 to Production #11188
Merged
Merged
Deploy RC 411 to Production #11188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Internal, Logging, Log the context of contextless KMS
changelog: Internal, Dependencies, Update dependency to resolve security advisory
…11148) * LG-14216: Implement configurable percent tested reCAPTCHA at sign-in changelog: Upcoming Features, Fraud Prevent, Implement configurable percent tested reCAPTCHA at sign-in * Add A/B testing concern to controller where used * Annotate reCAPTCHA result received event * Exclude from A/B test where captcha validation not performed * Determine exempt before captcha submission Move contextual arguments to constructor * Fix error unknown keywords * Add specs for AbTest should_log respond_to include * Add specs for ab_test_bucket user keyword argument * Update SignInRecaptchaForm specs * Avoid return statement in block * Document captcha_validation_performed * Force reCAPTCHA performed in feature spec * Update sessions controller asserted logging expectations * Handle nil user, user_session * Memoize user_from_params Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Use Array#to_set to avoid extra indentation See: #11148 (comment) Co-Authored-By: Zach Margolis <zachmargolis@users.noreply.github.com> * Reload A/B tests after stubbing bucket configuration A/B test constants are defined before the stubs go into effect, so they'll use the default even if stubbed with something different. Reload A/B tests after stub goes into effect / is torn down to force configuration to be used. * Reload A/B tests for enabled reCAPTCHA in sessions controlller * Stub controller ab_test_bucket * Add specs for AbTests:: RECAPTCHA_SIGN_IN * Default to always test in development * Replace user action events with application-facing --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
changelog: User-Facing Improvements, Connected Accounts, Return user to connected accounts when cancelling revocation
We want to start tracking how long it takes people to complete identity proofing. Part of that is understanding how long it takes people to go from the start of the process to the enter password step where their profile is created. At this point we want to know: 1. How long did it take the person to complete the workflow 2. What steps remain before person finishes proofing (i.e. verify-by-mail, in-person-proofing, or fraud review) The enter password submit events already logs enough information to determine the second. This commit starts tracking the duration of the proofing session by adding a timestamp at the welcome step and logging the elapsed seconds since on the enter password events.
* Add Socure configs to IdentityConfig * Add failure_message_when_negated to HaveLoggedEventMatcher * Add SocureShadowModeProofingJob Add job to make requests to Socure's KYC API and log the results alongside the original resolution proofing result. changelog: Upcoming Features, Identity verification, Add background job for Socure KYC proofing * Make ResolutionProofingJob schedule Socure KYC call - When flag is enabled, invoke Socure KYC as well * Add verified_attributes to resolution result to_h * Add more detail to resolution proofer logging test * Don't log TMX response body ong idv_socure_shadow_mode_proofing_result These are real big and mess with Cloudwatch's ability to parse fields out oflogs. * Tweak socure default base URL for dev * Remove pointless user_id arg to analytics event * Update app/jobs/socure_shadow_mode_proofing_job.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Clarify comment in spec * Clarify spec name * Clarify spec name * Use user.first_email * Revert "Use user.first_email" This reverts commit fd4dcab. * Remove pointless service_provider_issuer let --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* LG-14259 Update Report formatting\n\n changelog: Internal, Reporting, Update LG-99 Report Layout * changelog: Internal, Reporting, Update LG-99 Report Layout * LG-14259/update tests for fraud metrics * update lg99 columns * lumberjack code
* changelog: Internal, Webauthn Setup, Add aaguid for webauthn configuration * change to use backend uuid instead of front end * update and fix spec * update webauthn verification * update schema * log aaguid for webauthn * changelog: Internal, Authentication, add aaguid to webauthn configuration * remove unneeded migration * fix schema * add back fed email domains
jmhooper
approved these changes
Sep 3, 2024
mitchellhenke
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Internal
Upcoming Features