Add StatusPageComponent for standard status page layout #6140
Conversation
| renders_many :action_buttons, ->(**button_options) do | ||
| ButtonComponent.new(**button_options, big: true, wide: true) | ||
| end | ||
| renders_one :troubleshooting_options |
There was a problem hiding this comment.
Future work should adapt app/views/shared/_troubleshooting_options.html.erb into a component, so this could be implemented as a pass-through similar to PageHeadingComponent and ButtonComponent above.
| renders_one :troubleshooting_options | |
| renders_one :troubleshooting_options, ::TroubleshootingOptionsComponent |
| @@ -1,32 +1,13 @@ | |||
| class CancellationPresenter < FailurePresenter | |||
There was a problem hiding this comment.
yesss down with inheritance!
| <ul class="usa-list"> | ||
| <li><%= t('users.delete.bullet_1', app_name: APP_NAME) %></li> | ||
| <li><%= t('users.delete.bullet_2_loa1') %></li> | ||
| <li><%= t('users.delete.bullet_3', app_name: APP_NAME) %></li> | ||
| <li><%= t('users.delete.bullet_4', app_name: APP_NAME) %></li> | ||
| </ul> |
There was a problem hiding this comment.
should we consider refactoring to an array of translations while we're here? One bullet would get extra APP_NAME but that would be ok
There was a problem hiding this comment.
Hm, I like the idea. It's made complicated by the fact that these texts are reused for the "Delete Account" flow, where the second bullet point can have some variability.
identity-idp/app/views/users/delete/show.html.erb
Lines 10 to 13 in 48a6948
I'm not sure how best to handle that, or if it's worth the trouble to refactor it. I'll probably leave it out of this pull request though.
**Why**: To minimize developer effort and inconsistencies between status page implementations. changelog: Improvements, Accessibility, Add meaningful alternative text for failure error icon
Lots of lingering references to it, most of which will likely need to be ported to use StatusPageComponent
aduth
force-pushed
the
aduth-status-page-component
branch
from
2d0b1c9
to
3a4b7e8
Compare
Why:
Currently, this merges to #6129, since it implements the "ideal long-term solution" mentioned in #6129 (comment).
Future work would refactor to replace use of
app/views/idv/shared/_error.htmlto use this component instead, as they serve largely the same purpose.Testing:
rails cconsole:User.find_with_email('me@example.com').update!(second_factor_locked_at: Time.zone.now + 10.minutes)Screenshots:
(Note: There are not expected to be any visual differences with these changes)