Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt troubleshooting options to Rails component #6142

Merged
merged 11 commits into from
Apr 4, 2022

Conversation

aduth
Copy link
Member

@aduth aduth commented Apr 4, 2022

Why:

Dependency of TroubleshootingOptionsComponent
Internal, Components, Improve developer experience around status page troubleshooting options
<% end %>
</ul>
<% end %>
<%= render TroubleshootingOptionsComponent.new do |c| %>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't yet remove the partial, since it's used in quite a few places that would need to be updated. I could do it here, but figured it better to limit the size of the changes.

changelog: Internal, Components, Improve developer experience around status page troubleshooting options
While it wouldn't be an issue in practice, specs are set up to assume "nil" can be passed explicitly. Also better matches previous behavior
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth aduth merged commit f161415 into main Apr 4, 2022
@aduth aduth deleted the aduth-troubleshooting-options branch April 4, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants