Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use new ceramic one metric for validation #182

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

dav1do
Copy link
Contributor

@dav1do dav1do commented Jun 6, 2024

Update metric to match renames in rust ceramic. We fall back to old one if new doesn't exist so it should pass in CI/tests for either version of c1.

made count optional so we can tell if we should fallback to the old one
Copy link
Collaborator

@smrz2001 smrz2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@samika98 samika98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@3benbox 3benbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dav1do dav1do added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit 03bec17 Jun 18, 2024
5 checks passed
@dav1do dav1do deleted the chore/c1-metrics-rename branch June 18, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants