chore: rename prometheus registry and metrics for better consistency #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav1do
requested review from
stbrody,
smrz2001,
nathanielc,
kammerdiener and
3benbox
dav1do
force-pushed
the
chore/c1-metrics-registry
branch
from
ef1a9b3
to
2ec8311
Compare
was "ceramic_store_store_query_durations" and with the new c1 prefix "ceramic_one_ceramic_store_store_query_durations" and now "ceramic_one_store_query_durations"
dav1do
force-pushed
the
chore/c1-metrics-registry
branch
from
2ec8311
to
8b75a9c
Compare
|
I'm waiting to merge this as I want to make sure it doesn't break the keramik tests.. but they are already a bit broken due to rejecting events we don't recognize and being on different versions i.e. the http-client-rs changes need to land. On the docket for next week. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will break existing dashboards (of which there are few well defined examples I believe), but it will make building new ones much easier as all metrics will start with
ceramic_one_now. This also renamedhttp_api_http_apitoceramic_one_http_api_infoandceramic_store_store_query_durationswill now beceramic_one_store_query_durations, and other store metrics will be underceramic_one_store.The existing tokio, recon, libp2p, bitswap subregistries are all under ceramic_one now:
