-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Create milestone #391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we don't want integration tests for this one?
LGTM 👍
@@ -314,4 +314,24 @@ trait Issues[F[_]] { | |||
headers: Map[String, String] = Map() | |||
): F[GHResponse[List[Milestone]]] | |||
|
|||
/** | |||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing doc
title: String, | ||
state: Option[String], | ||
description: Option[String], | ||
due_on: Option[String], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if in these cases it wouldn't be better to supply a value of type date and format it ourselves, wdyt? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree, it looks like we'll need a ZonedDateTime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Codecov Report
@@ Coverage Diff @@
## master #391 +/- ##
===========================================
+ Coverage 78.71% 92.72% +14.00%
===========================================
Files 23 23
Lines 531 536 +5
Branches 2 2
===========================================
+ Hits 418 497 +79
+ Misses 113 39 -74
Continue to review full report at Codecov.
|
Implement https://developer.github.com/v3/issues/milestones/#create-a-milestone