-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Create milestone #391
Changes from 4 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -314,4 +314,24 @@ trait Issues[F[_]] { | |
headers: Map[String, String] = Map() | ||
): F[GHResponse[List[Milestone]]] | ||
|
||
/** | ||
* | ||
* @param owner repo owner | ||
* @param repo repo name | ||
* @param title The title of the milestone. | ||
* @param state The state of the milestone. Either open or closed. Default: open | ||
* @param description A description of the milestone. | ||
* @param due_on The milestone due date. This is a timestamp in ISO 8601 format: YYYY-MM-DDTHH:MM:SSZ. | ||
* @param headers optional user headers to include in the request | ||
* @return a GHResponse with the created Milestone | ||
*/ | ||
def createMilestone( | ||
owner: String, | ||
repo: String, | ||
title: String, | ||
state: Option[String], | ||
description: Option[String], | ||
due_on: Option[String], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wonder if in these cases it wouldn't be better to supply a value of type date and format it ourselves, wdyt? 🤔 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I agree, it looks like we'll need a ZonedDateTime |
||
headers: Map[String, String] = Map() | ||
): F[GHResponse[Milestone]] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing doc