-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbreak the build (fix #586 #597) #595
Conversation
Marked WIP as there seems to be another test failing. Not sure if it should hold up the fix. |
9188177
to
09a3b4d
Compare
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
==========================================
- Coverage 90.29% 90.18% -0.12%
==========================================
Files 25 25
Lines 608 611 +3
Branches 3 1 -2
==========================================
+ Hits 549 551 +2
- Misses 59 60 +1
Continue to review full report at Codecov.
|
Ok, after a lot of trial and error (Metals was not reporting any of the errors that github found) I've turned this PR into fixing the build entirely, and edited the description to match. Code coverage is slightly down but I don't think that's an issue since it's a result of one test being removed (as the feature was removed) and then one test being ignored (as the issue states). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fixes the build by solving two separate issues:
Auth.newAuth
functionality as logging in with a username/password is now officially discontinued (Remove Auth.newAuth as it has been discontinued #597)This includes the requisite changes to documentation as well as a quick tweak to the
.gitignore
to properly filter outmetals.sbt
in all directories.