Fix #569 - Manually encode Uri query parameters #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloshy
force-pushed
the
fix/569-issues-url-encoding
branch
from
d40bbaa
to
2ec3411
Compare
|
Tests are failing, partial fix is in #595 (review appreciated) but the tests for this that were added pass. |
sloshy
force-pushed
the
fix/569-issues-url-encoding
branch
from
2ec3411
to
5c61416
Compare
sloshy
force-pushed
the
fix/569-issues-url-encoding
branch
from
5c61416
to
aefdf2b
Compare
juanpedromoreno
approved these changes
Jan 13, 2021
Codecov Report
@@ Coverage Diff @@
## master #596 +/- ##
==========================================
+ Coverage 90.18% 90.22% +0.04%
==========================================
Files 25 25
Lines 611 614 +3
Branches 1 4 +3
==========================================
+ Hits 551 554 +3
Misses 60 60
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #569. The solution to the issue of query parameters being encoded incorrectly lies within a recently-added workaround in http4s,
Query.fromString, which preserves the string you pass to it without trying to apply its own encoding rules.Please let me know if the tests could be improved or if there is more documentation required.