-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
f64 support for distribution metric type #131
Comments
A PR that mirrors the way |
Actually @mbellani, I've got some changes that I've been meaning to put up for a PR that will make the value for each metric call generic and remove the need for suffixed methods like |
@56quarters that sounds good to me, I'm not in a hurry, we currently have an implementation of |
Add support for emiting f64 types for histograms and distributions and clean up some the StatsdClient tests. Fixes #131
Add support for emiting f64 types for histograms and distributions and clean up some the StatsdClient tests. Fixes #131
Add support for emiting f64 types for histograms and distributions and clean up some the StatsdClient tests. Fixes #131 Signed-off-by: Nick Pillitteri <nick@56quarters.xyz>
Thanks for adding distribution metric type support to cadence. It looks like the value types supported for distribution are only
u64
. There are cases however where distribution can be reported in fractions and it would be really great to either add that interface or change the type fromu64
tof64
. DataDog's datagram format does support both float and an integer, we currently use it this way in a custom metric type that we created. Also happy to open a PR if you like.Thanks for all your work this library.
The text was updated successfully, but these errors were encountered: