Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for distribution metric type #125

Merged
merged 4 commits into from
Mar 16, 2021

Conversation

duarten
Copy link
Contributor

@duarten duarten commented Mar 16, 2021

This PR adds support for the Datadog-specific distribution metric type, documented here.

Copy link
Owner

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, amazing work! One small change requested

/// `MetricBuilder` that can be used to add tags to the metric.
fn distribution_with_tags<'a>(&'a self, key: &'a str, value: u64) -> MetricBuilder<'_, '_, Distribution>;

/// Record a single distribution value with the given key.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't have a specific usecase for treating these as times, would you mind removing the duration methods? They were added to Histograms (in Cadence) after the fact by request. I'd rather not add extra methods unless people specifically need them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do!

@56quarters 56quarters self-requested a review March 16, 2021 20:58
Copy link
Owner

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@56quarters 56quarters merged commit cda3455 into 56quarters:master Mar 16, 2021
@duarten
Copy link
Contributor Author

duarten commented Mar 18, 2021

@56quarters, if it's not too much trouble, would you be able to cut a release containing the distribution stuff? :)

@56quarters
Copy link
Owner

56quarters commented Mar 18, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants