GraphQL Name Collision in overly aggressive "ToGo" conversion

[dcarbone]

What happened?

I have a GraphQL schema with the following Enum:

enum MyEnum {
  Value
  value
  TitleValue
  title_value
}

And so-on. This, unfortunately, is forcibly turned into:

type MyEnum string

const (
  MyEnumValue MyEnum = "Value"
  MyEnumValue MyEnum = "value"
  MyEnumTitleValue MyEnum = "TitleValue"
  MyEnumTitleValue MyEnum = "title_value"
)

The obvious issue here is that we have two consts with the same name, but different values.

What did you expect?

The consts to be defined as

type MyEnum string

const (
  MyEnumValue MyEnum = "Value"
  MyEnumvalue MyEnum = "value"
  MyEnumTitleValue MyEnum = "TitleValue"
  MyEnumtitle_value MyEnum = "title_value"
)

or some derivative thereof. Perhaps with an underscore in between the $enum.Name and .Name to make them more readable.

I am working on a PR on this, but I wanted to open this and get some feedback on possible alternative solutions.

Minimal graphql.schema and models to reproduce

enum MyEnum {
  Value
  value
  TitleValue
  title_value
}

versions

• gqlgen version: v0.17.13
• go version: go1.18.5

[dcarbone]

closed with #2322