Avoid GraphQL to Go Naming Collision with "ToGoModelName" func #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcarbone
force-pushed
the
dcarbone/name-fixes
branch
from
eb668fa
to
89e3a71
Compare
dcarbone
force-pushed
the
dcarbone/name-fixes
branch
from
88e3bd0
to
9f6d51e
Compare
StevenACoffman
changed the title
|
If this solution is acceptable, I think I should do the same for the "private" name func, yeah? |
|
Looks like a failing test after this latest update. Thanks for sticking with this! |
|
@StevenACoffman yep, sorry, yesterday got busy. Working on it now :) |
|
@StevenACoffman looks like all the things are happy. any additional changes you'd like made? |
|
Thanks for sticking with it! This is a nice improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass attempt at addressing #2321. There are some edge cases, as described in the documentation, but I believe it to be about the best possible until the generator is altered to take a high-level look at every single possile generated name before templating even starts, and handles resolution there.
I have: