Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid GraphQL to Go Naming Collision with "ToGoModelName" func #2322

Merged
merged 9 commits into from
Aug 18, 2022

Conversation

dcarbone
Copy link
Contributor

This is a first pass attempt at addressing #2321. There are some edge cases, as described in the documentation, but I believe it to be about the best possible until the generator is altered to take a high-level look at every single possile generated name before templating even starts, and handles resolution there.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

coveralls commented Aug 16, 2022

Coverage Status

Coverage increased (+0.9%) to 75.439% when pulling 74b342e on dcarbone:dcarbone/name-fixes into 2304c10 on 99designs:master.

@StevenACoffman StevenACoffman changed the title Add "ToGoModelName" func Avoid GraphQL to Go Naming Collision with "ToGoModelName" func Aug 16, 2022
@dcarbone
Copy link
Contributor Author

If this solution is acceptable, I think I should do the same for the "private" name func, yeah?

@StevenACoffman
Copy link
Collaborator

Looks like a failing test after this latest update. Thanks for sticking with this!

@dcarbone
Copy link
Contributor Author

@StevenACoffman yep, sorry, yesterday got busy. Working on it now :)

@dcarbone
Copy link
Contributor Author

@StevenACoffman looks like all the things are happy. any additional changes you'd like made?

@StevenACoffman StevenACoffman merged commit 9f919d2 into 99designs:master Aug 18, 2022
@StevenACoffman
Copy link
Collaborator

Thanks for sticking with it! This is a nice improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants