-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add FTV1 Support via Handler #2132
Conversation
Also- if there's a good way to note to coveralls that the protobuf/generated files can be exempt, that'd be ideal since the length of both files is tanking overall coverage. |
@@ -14,3 +14,4 @@ | |||
.idea/ | |||
*.test | |||
*.out | |||
gqlgen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
See #2133 |
Also, looks like you need to run:
|
Same as last time: apollographql/apollo-federation-subgraph-compatibility#89 Will get that pushed through to get it updated. |
This adds the ability to properly respond to Apollo Federation v1 (aka
ftv1
) headers with traces to support field-level traces within Apollo Studio. This feature is entirely optional, and would be opted in as with the existing Apollo Tracing handler.Sample: https://github.com/lleadbet/apollo-gqlgen-ftv1/blob/master/server.go#L24
To support this, there are two major changes:
RawParams
to support passing request headers to HandlersBeyond that, it adds the plugin itself alongside the source of the protobuff file to be able to use as reference.
Not sure where docs should be updated, however.
I have: