Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gqlgen: FTV1 Support Test #89

Merged
merged 5 commits into from
Apr 29, 2022
Merged

gqlgen: FTV1 Support Test #89

merged 5 commits into from
Apr 29, 2022

Conversation

lleadbet
Copy link
Contributor

Following up on #87, this PR adds the relevant flag to support ftv1 requests and sends back proper traces.

As with the previous PR, this pins gqlgen to 99designs/gqlgen@9250f9a until it is cut in a release, but the updated results will remain the same for now. For posterity, the updated results are here:

Language Library Federation 1 Support Federation 2 Support
Go gqlgen
_service
@key (single)
@key (multi)
@key (composite)
@requires
@provides
@ftv1
@link
@Shareable
@tag
@OverRide
@inaccessible

PS: I believe this is the first non-Apollo library to be fully Fed2 subgraph compliant!

@StevenACoffman
Copy link
Contributor

v0.17.5 is now released

@lleadbet lleadbet marked this pull request as ready for review April 29, 2022 14:36
@hwillson hwillson self-requested a review April 29, 2022 15:26
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing - thanks very much @lleadbet! 🎉

@hwillson hwillson merged commit 1ef6574 into apollographql:main Apr 29, 2022
@lleadbet lleadbet deleted the ftv1_support branch May 1, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants