-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #2485 for some types requiring a scalar #2508
Conversation
@@ -257,6 +257,30 @@ func (t *TypeReference) IsUnderlyingBasic() bool { | |||
return isUnderlyingBasic | |||
} | |||
|
|||
func (t *TypeReference) IsUnusualBasic() bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I named these as Unusual
but a suggestion for a better name is welcomed.
This commit actually broke our app, it generates invalid code when trying to unmarshal typed scalars. It evens breaks
which causes this error:
Here is another example with a pointer type
|
@mojtabacazi Did #2528 fix your issue? |
also related: #2486 |
Nope, still an issue in v0.17.26 |
Signed-off-by: Steve Coffman <steve@khanacademy.org>
@mojtabacazi I reverted this, so please see if v0.17.27 resolves your issue! |
Following PR # 2486, some types require a scalar to work properly. This PR fixes some of them except
float32
anduint64
. The reasons are as follow:I have: