Revert mstephano #2486 #2508 #2528 #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Coffman <steve@khanacademy.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert @mstephano PRs #2486 #2508 #2528
Fixes #2561 #2550 #2580 and possibly others
Originally, these PRs were intended to fix
#2485 Defined type from a basic type should not need a mandatory scalar + MarshalFunc and UnmarshalFunc
However, the cure was worse than the disease, and it has led to a variety of problems. The original author of the PRs is not currently available to continue to refine his solution, so I am reverting it until someone can avoid the myriad problems this has caused.