Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert mstephano #2486 #2508 #2528 #2587

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Revert mstephano #2486 #2508 #2528 #2587

merged 1 commit into from
Mar 20, 2023

Conversation

StevenACoffman
Copy link
Collaborator

Revert @mstephano PRs #2486 #2508 #2528

Fixes #2561 #2550 #2580 and possibly others

Originally, these PRs were intended to fix
#2485 Defined type from a basic type should not need a mandatory scalar + MarshalFunc and UnmarshalFunc

However, the cure was worse than the disease, and it has led to a variety of problems. The original author of the PRs is not currently available to continue to refine his solution, so I am reverting it until someone can avoid the myriad problems this has caused.

Signed-off-by: Steve Coffman <steve@khanacademy.org>
@StevenACoffman StevenACoffman merged commit aab9b96 into master Mar 20, 2023
@StevenACoffman StevenACoffman deleted the revert_mstephano branch March 20, 2023 16:32
@coveralls
Copy link

Coverage Status

Coverage: 78.806% (+3.8%) from 74.987% when pulling 9dbafba on revert_mstephano into 05500c9 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

custom types are no longer used to ID model since v0.17.24
2 participants