DT_THERM=6*DT and DIABATIC_FIRST = False

[aekiss]

use DT_THERM=6*DT and DIABATIC_FIRST = False - see COSIMA/access-om3#138

[minghangli-uni]

It is not necessarily to change the value of ocn_cpl_dt unless stop_option is nsteps. I can do a cherry pick to add comments right after this parameter for all configurations. COSIMA/access-om3#157 (comment)

[minghangli-uni]

Thanks @aekiss LGTM!

[aekiss]

!cherry-pick ac53042 c18a988 into 1deg_jra55do_iaf

[github-actions]

!cherry-pick ac53042 c18a988 into 1deg_jra55do_iaf

Automatic cherry-pick failed. Could not find commit(s) ac53042 c18a988 in 1deg_jra55do_ryf.

[aekiss]

!cherry-pick 58e3b75 2d639fe into 1deg_jra55do_iaf

[github-actions]

Automatic Git cherry-picking of commit(s) 58e3b75 2d639fe into 1deg_jra55do_iaf failed. This usually happens when cherry-picking results in a conflic or an empty commit. To manually cherry-pick the commits and open a pull request, please follow these instructions:

1. Create new branch from target branch:

git checkout 1deg_jra55do_iaf
git pull
git checkout -b cherry_pick_from_pr94_into_1deg_jra55do_iaf

2. Cherry-pick commits:

git cherry-pick 58e3b755e8e09664f4c8eedb40f428ce215a4bfb 2d639fe009f92860169677b18990864317f0a9ca

3. Fix any conflicts and/or empty commits by following the instructions provided by Git.
4. Push the new branch:

git push --set-upstream origin cherry_pick_from_pr94_into_1deg_jra55do_iaf

5. Open a new pull request on github making sure the target branch is set to 1deg_jra55do_iaf.

[minghangli-uni]

Hi @aekiss It seems that your cherry-picks failed because of the conflicts. You might need to follow the steps from #94 (comment)

[aekiss]

OK I'm working on it. The biggest conflict is due to differing MOM_input formats - see COSIMA/access-om3#200

[dougiesquire]

I was under the impression we weren't going to change these params in our official config branches until we'd done the testing to determine what DT_THERM is optimal. Are we confident this value gives okay results?

[aekiss]

Ah yes, good point. Sorry if I jumped the gun there. I'll wait until we've tested before merging this into 1deg_jra55do_iaf.