Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various problems #93

Merged
merged 8 commits into from
Oct 8, 2024
Merged

Various problems #93

merged 8 commits into from
Oct 8, 2024

Conversation

gritya
Copy link
Collaborator

@gritya gritya commented Oct 7, 2024

rewrote tests, corrected bug that duplicates some events, corrected bug when input data problems in for 10mn weather data sampling stations

@madrouin
Copy link
Contributor

madrouin commented Oct 8, 2024

  • I updated all pre-commit
  • I made a temporay fix by deactivating the docformatter pre-commit.

The pre-commit need an update because of the last update of pre-commit package: PyCQA/docformatter#287

There is least one file with a hardcoded path: ccres_disdrometer_processing/timestep_histogram_2periods.py.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 98.14815% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.71%. Comparing base (cec2074) to head (613a5a2).
Report is 19 commits behind head on develop.

Files with missing lines Patch % Lines
ccres_disdrometer_processing/quicklooks_1event.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #93      +/-   ##
===========================================
+ Coverage    55.82%   56.71%   +0.89%     
===========================================
  Files           24       23       -1     
  Lines         2909     2902       -7     
  Branches       270      275       +5     
===========================================
+ Hits          1624     1646      +22     
+ Misses        1257     1225      -32     
- Partials        28       31       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gritya gritya merged commit b296ee8 into develop Oct 8, 2024
12 checks passed
@madrouin madrouin deleted the various_problems branch October 22, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants