🩹 Fix pre commit hook manifest

[s-weigand]

pre-commit just released v4.0.0 with the breaking change that language: python_venv was removed.
This breaks docformatter hook config at parse time, even for users that don't use docformatter-venv (e.g. I use the "normal" docformatter hook).
The error is:

An error has occurred: InvalidManifestError: 
==> File /home/runner/.cache/pre-commit/repocernquz3/.pre-commit-hooks.yaml
==> At Hook(id='docformatter-venv')
==> At key: language
=====> Expected one of conda, coursier, dart, docker, docker_image, dotnet, fail, golang, haskell, lua, node, perl, pygrep, python, r, ruby, rust, script, swift, system but got: 'python_venv'
Check the log at /home/runner/.cache/pre-commit/pre-commit.log

In addition to removing docformatter-venv I also added the pre-commit built-in validate_manifest hook to check the hook manifest.
And for the linter CI to pass I had to add some additional fixes, since it seems to be broken since Aug 9, 2023 (most likely due to a tool update but the CI logs are already gone)

Additional info:

language: python_venv has been deprecated Feb 4, 2023 and should have emitted a warning since then based on the code.
However, in my last CI run using that passed pre-commit successfully and without warning (pre-commit==3.8.0).

...
[INFO] Installing environment for https://github.com/PyCQA/docformatter.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/MarcoGorelli/absolufy-imports.
...

Furthermore the built-in validate_manifest hook in pre-commit==3.8.0 also didn't have an issue with language: python_venv.
So it seems like there was no easy way to get a heads-up, except closely following the pre-commitchangelog.

Edit:
Now I get why there was no warning when pre-commit did setup the env for docformatter, it's because I used the docformatter hook and the warning would only be shown when someone actually uses the docformatter-venv hook.

[s-weigand]

Also thanks a lot for the project and its maintenance ❤

[s-weigand]

See also #289

[dakl]

This would be great to get in! 🙌

[webknjaz]

@weibullguy you merged a topic-related PR in the past (#266). Perhaps you could accept this one too?

[grochmal]

Great work @s-weigand , just hit this today. I search for it and there is already a PR in the works. Thank you!

[danilogco]

I hope it gets approved soon. Gg

[Woody1193]

This is currently breaking all our workflows so I do hope it's approved soon.

[snarayan21]

Breaking our workflows as well, hope this gets merged + released soon!

[webknjaz]

Folks, please be mindful that every new comment sends a notifications storm to many people. Especially, since one maintainer has been pinged already. Those who commented before and those who just subscribed to updates. A bunch of “me too” / “+1” / “when will this get merged” / “when will this get released” duplicate notifications is definitely not something that is useful for every single person to receive, nor does it help get this merged. It just leads to having a lot of pointless notifications in people's inboxes, which is unhelpful to say the least. Please avoid adding more similar comments that are not contributing to advancing the topic of the PR. Please also be mindful that the maintainers might not be able to do anything for a while, regardless of the number of comments. Thank you in advance.

[s-weigand]

For the impatient, there are 3 workarounds until maintainers have time:

1. Set an upper bound of pre-commit<4
2. Comment out the hook in your .pre-commit-config.yaml
3. Use the fix commit from my PR branch (you should not use branches from random ppl off the internet 😅)
   E.g.:

  # TODO: Switch back to upstream docformatter 
  # after https://github.com/PyCQA/docformatter/issues/289 is fixed
  - repo: https://github.com/s-weigand/docformatter
    rev: 1ec30b7
    hooks:
      - id: docformatter
        additional_dependencies: [tomli]
        args: [--in-place, --config, ./pyproject.toml]

Also, be patient with maintainers, this is FOSS and no one is entitled to anything. 😉

[webknjaz]

Alternatively, you can drop the dependency on GitHub and replace it with the last PyPI release:

---

ci:
  autoupdate_schedule: quarterly  # low frequency to reduce maintenance noise

hooks:
- repo: local
  hooks:
  - id: docformatter
    name: docformatter
    description: Formats docstrings to follow PEP 257.
    entry: python -Im docformatter
    additional_dependencies:
    - docformatter == 1.7.5
    args:
    - --in-place
    language: python
    types:
    - python

...

[setu4993]

Bump. Been over a month since this was merged, would be good to create a new release with this change.

[mjspeck]

Bump. Been over a month since this was merged, would be good to create a new release with this change.

Seriously, why hasn't this been released yet?