Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish riemann cleaning #2897

Merged
merged 41 commits into from
Jul 10, 2024
Merged

Finish riemann cleaning #2897

merged 41 commits into from
Jul 10, 2024

Commits on Jun 26, 2024

  1. fix some namespace issues + add missing headers to runtime_parameters.H 

    this will make it easier to use this for non-castro things (like
exact_riemann)
    @zingale
    zingale committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    fe81e5d View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. more work on getting castro params into exact Riemann

    @zingale
    zingale committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    000768f View commit details
    Browse the repository at this point in the history

  2. this seems to work

    @zingale
    zingale committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    d01fa53 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'development' into exact_riemann_castro_params

    @zingale
    zingale committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    94d35b2 View commit details
    Browse the repository at this point in the history

  4. this works now

    @zingale
    zingale committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    a4a16d3 View commit details
    Browse the repository at this point in the history

  5. add missing file

    @zingale
    zingale committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    b0b48bb View commit details
    Browse the repository at this point in the history

  6. Merge branch 'development' into exact_riemann_castro_params

    @zingale
    zingale authored Jun 27, 2024
    Configuration menu
    Copy the full SHA
    c08294d View commit details
    Browse the repository at this point in the history

  7. Merge branch 'development' into exact_riemann_castro_params

    @zingale
    zingale authored Jun 27, 2024
    Configuration menu
    Copy the full SHA
    afcb2dc View commit details
    Browse the repository at this point in the history

  8. unused header

    @zingale
    zingale committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    8b81044 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'exact_riemann_castro_params' of github.com:zingale/Cast… 

    …ro into exact_riemann_castro_params
    @zingale
    zingale committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    a3c59f6 View commit details
    Browse the repository at this point in the history

  10. rename some Riemann runtime parameters 

    now they have "riemann" in their name, and also some
drop "cg" so that it is clear that they can apply to other
solvers
    @zingale
    zingale committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    372229c View commit details
    Browse the repository at this point in the history

  11. fix runtime params

    @zingale
    zingale committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    1f3a733 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Merge branch 'rename_riemann_runtime' into next_exact_riemann

    @zingale
    zingale committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    07307ec View commit details
    Browse the repository at this point in the history

  2. work on using Source/hydro riemann parameters

    @zingale
    zingale committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    f6363f2 View commit details
    Browse the repository at this point in the history

  3. move some Riemann history constexpr to riemann_constants namespace

    @zingale
    zingale committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    03b9653 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'move_history_params_to_riemann' into next_exact_riemann

    @zingale
    zingale committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    ad30404 View commit details
    Browse the repository at this point in the history

  5. split constants into riemann_constants.H 

    allow the exact Riemann solver to use the new constants
    @zingale
    zingale committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    9e7e820 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'development' into exact_riemann_castro_params

    @zingale
    zingale committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    0d51f94 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'exact_riemann_castro_params' into move_history_params_t… 

    …o_riemann
    @zingale
    zingale committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    a3f5802 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'move_history_params_to_riemann' into next_exact_riemann

    @zingale
    zingale committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    a932e27 View commit details
    Browse the repository at this point in the history

  9. remove unneeded header

    @zingale
    zingale committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    9b1cf4d View commit details
    Browse the repository at this point in the history

  10. more work on getting the Riemann solver to fully use Castro stuff

    @zingale
    zingale committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    0a6ce88 View commit details
    Browse the repository at this point in the history

  11. for pstar convergence in exact_riemann use std::abs()

    @zingale
    zingale committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    17431ba View commit details
    Browse the repository at this point in the history

  12. remove the ustar test

    @zingale
    zingale committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    65a818c View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Merge branch 'development' into move_history_params_to_riemann

    @zingale
    zingale authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    d3f70a6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'development' into next_exact_riemann

    @zingale
    zingale authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    4a134a9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'development' into finish_riemann_cleaning

    @zingale
    zingale authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    6aa51c3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'development' into fix_exact_riemann_pstar_test

    @zingale
    zingale authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    bbcd4d8 View commit details
    Browse the repository at this point in the history

  5. fix header guard

    @zingale
    zingale committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    22a9572 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'next_exact_riemann' into finish_riemann_cleaning

    @zingale
    zingale committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    a204219 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Merge branch 'development' into move_history_params_to_riemann

    @zingale
    zingale committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    75a7724 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'move_history_params_to_riemann' into finish_riemann_cle… 

    …aning
    @zingale
    zingale committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    166c276 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'move_history_params_to_riemann' into next_exact_riemann

    @zingale
    zingale committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    06a8d20 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'next_exact_riemann' into finish_riemann_cleaning

    @zingale
    zingale committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    cfc0071 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'development' into next_exact_riemann

    @zingale
    zingale committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    2ad23f4 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'next_exact_riemann' into finish_riemann_cleaning

    @zingale
    zingale committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    2f458f6 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'development' into fix_exact_riemann_pstar_test

    @zingale
    zingale committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    51f2c9f View commit details
    Browse the repository at this point in the history

  8. Merge branch 'fix_exact_riemann_pstar_test' into finish_riemann_cleaning

    @zingale
    zingale committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    f5b4dfe View commit details
    Browse the repository at this point in the history

  9. more cleaning

    @zingale
    zingale committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    3fb9b51 View commit details
    Browse the repository at this point in the history

  10. finish

    @zingale
    zingale committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    51313d2 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. rename

    @zingale
    zingale committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    2a1a272 View commit details
    Browse the repository at this point in the history