Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rotating reference frames capability #850

Merged
merged 50 commits into from
Oct 22, 2024
Merged

rotating reference frames capability #850

merged 50 commits into from
Oct 22, 2024

Conversation

hsitaram
Copy link
Contributor

This PR adds the capability to do rotating reference frames in PeleC relevant for turbomachinery applications. The equations will be solved in the non-inertial reference frame with momentum source terms and modified total energy.

@hsitaram hsitaram requested a review from baperry2 September 27, 2024 03:35
Source/Derive.cpp Fixed Show fixed Hide fixed
Source/Hydro.H Fixed Show fixed Hide fixed
Source/IO.cpp Fixed Show fixed Hide fixed
Source/InitEB.cpp Fixed Show fixed Hide fixed
Source/Soot.cpp Fixed Show fixed Hide fixed
@baperry2
Copy link
Contributor

baperry2 commented Oct 8, 2024

A quick note here: users will have to account for the rotational frame in ProblemSpecificFunctions::problem_eb_state if using that capability in conjunction with rotational frame simulations

Exec/RegTests/EB-Rotor4Blade/prob.H Fixed Show fixed Hide fixed
Exec/RegTests/EB-Rotor4Blade/prob.H Fixed Show fixed Hide fixed
Exec/RegTests/EB-TaylorCouette/prob.H Fixed Show fixed Hide fixed
Exec/RegTests/EB-TaylorCouette/prob.H Fixed Show fixed Hide fixed
Copy link
Contributor

@baperry2 baperry2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New cases appear to be working and this doesn't affect existing cases.

@baperry2 baperry2 enabled auto-merge (squash) October 22, 2024 17:34
@baperry2 baperry2 merged commit 203736c into development Oct 22, 2024
14 checks passed
@baperry2 baperry2 deleted the mrf branch October 22, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants