-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Update GitHub Actions workflow to use GCC 11 #628
Conversation
Updates the GitHub Actions workflow to use GCC 11 (instead of GCC 10) on the Ubuntu and macOS runs.
Rebased |
@y-guyon @wantehchang I'm doing some cleanup of old, open PRs. If you would like to get these changes in, please leave a reply or review. In two weeks I will close this PR if no reaction received. |
if: runner.os == 'Linux' | ||
run: echo "CC=gcc-10" >> $GITHUB_ENV && echo "CXX=g++-10" >> $GITHUB_ENV | ||
run: echo "CC=gcc-11" >> $GITHUB_ENV && echo "CXX=g++-11" >> $GITHUB_ENV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated, but could this simply be an env:
entry? Or is there something special about the use of $GITHUB_ENV here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the git blame, I modified it in PR #595 about one and a half years ago. I think this has to do with this issue:
Or it has to do with retention between steps.
But I don't remember exactly anymore. We could try if it works with a regular env:
, if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this change we can leave it as is. I was just curious when comparing other workflow files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also migrate other GitHub workflows such as ci-unix-shared.yml
?
GCC 13 is out. Should we update all the CI? Or maybe use that action? https://github.com/marketplace/actions/install-gcc |
Closing in favor of #1886 |
Updates the GitHub Actions workflow to use GCC 11 (instead of GCC 10) on the Ubuntu and macOS runs.
GCC 11 was added to the Ubuntu 20.04 environment earlier this month.