Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update GitHub Actions workflow to use GCC 11 #628

Closed
wants to merge 2 commits into from
Closed

CI: Update GitHub Actions workflow to use GCC 11 #628

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7ce27d
CI: Update GitHub Actions workflow to use GCC 11
EwoutH May 18, 2021
2990009
Merge branch 'main' into patch-34
EwoutH Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,12 @@ jobs:

steps:
- uses: actions/checkout@v3
- name: Set GCC & G++ 10 compiler (on Linux)
- name: Set GCC & G++ 11 compiler (on Linux)
if: runner.os == 'Linux'
run: echo "CC=gcc-10" >> $GITHUB_ENV && echo "CXX=g++-10" >> $GITHUB_ENV
run: echo "CC=gcc-11" >> $GITHUB_ENV && echo "CXX=g++-11" >> $GITHUB_ENV
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated, but could this simply be an env: entry? Or is there something special about the use of $GITHUB_ENV here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the git blame, I modified it in PR #595 about one and a half years ago. I think this has to do with this issue:

Or it has to do with retention between steps.

But I don't remember exactly anymore. We could try if it works with a regular env:, if you want.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this change we can leave it as is. I was just curious when comparing other workflow files.

- uses: actions/setup-python@v4
with:
python-version: '3.x'

- name: Cache external dependencies
id: cache-ext
uses: actions/cache@v3
Expand Down