Remove proxy and manager contracts and packages #444
Conversation
This reverts commit 454acd7.
Deploying abstract-docs with
|
| Latest commit: |
a6b08a0
|
| Status: | ⚡️ Build in progress... |
I kind of like the current convention we have as well. pub mod state {
// Constants
// Types
}
// Messages
// Responses |
…-remove-proxy-and-manager-contractsmods
| /// Add the message's data to the response | ||
| pub fn forward_response_data(result: Reply) -> AccountResult { | ||
| // get the result from the reply | ||
| let res = result.result.into_result().map_err(StdError::generic_err)?; | ||
|
|
||
| // log and add data if needed | ||
| let resp = if let Some(data) = res.data { | ||
| AccountResponse::new( | ||
| "forward_response_data_reply", | ||
| vec![("response_data", "true")], | ||
| ) | ||
| .set_data(data) | ||
| } else { | ||
| AccountResponse::new( | ||
| "forward_response_data_reply", | ||
| vec![("response_data", "false")], | ||
| ) | ||
| }; | ||
|
|
||
| Ok(resp) | ||
| } |
There was a problem hiding this comment.
@CyberHoward do we even need this method in cosmwasm 2? Won't it be possible to get data from the new field of SubMsgResponse: https://docs.rs/cosmwasm-std/latest/cosmwasm_std/struct.SubMsgResponse.html#structfield.msg_responses? Let's mark this method as deprecated for reminder as well if so
There was a problem hiding this comment.
I think it's the same behavior here, because it's still a nested execution.
We could have a test for thoses two cases, but I don't think it's deprecated yet
There was a problem hiding this comment.
Asked for clarification here : CosmWasm/cosmwasm#2253
There was a problem hiding this comment.
@CyberHoward do we even need this method in cosmwasm 2? Won't it be possible to get data from the new field of SubMsgResponse: https://docs.rs/cosmwasm-std/latest/cosmwasm_std/struct.SubMsgResponse.html#structfield.msg_responses? Let's mark this method as deprecated for reminder as well if so
Yeah I removed the allow(deprecated)
But we should do this in a different PR imo.
… of github.com:AbstractSDK/abstract into nicolas/abs-513-remove-proxy-and-manager-contractsmods
CyberHoward
deleted the
nicolas/abs-513-remove-proxy-and-manager-contractsmods
branch
This PR aims at removing the manager and proxy contracts completely from the repository
Checklist