Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account self registration #446

Merged
merged 48 commits into from
Sep 12, 2024
Merged

Account self registration #446

merged 48 commits into from
Sep 12, 2024

Conversation

CyberHoward
Copy link
Contributor

This PR adds and tests the self-registration logic for new Abstract Accounts.

Checklist

  • CI is green.
  • Changelog updated.

CyberHoward and others added 20 commits September 6, 2024 11:06
@CyberHoward
Rename AccountBase to Account
d04d23b
@CyberHoward
formatting [skip ci]
36f8af0
@CyberHoward
Merge remote-tracking branch 'origin/buckram/cosmwasm-2.0-bump' into …
b2cc11f 
…robin/abs-504-account-self-registration
@CyberHoward
renames
f244c1b
@CyberHoward
formatting [skip ci]
8ce4138
@CyberHoward
remove proxy / manager getters
a5f35d6
@CyberHoward
Advance Account change
d38d796
@CyberHoward
proceed with merge
0976174
@CyberHoward
formatting [skip ci]
03196c1
@CyberHoward
make things compile
8f3ba9a
@CyberHoward
formatting [skip ci]
3913c18
@CyberHoward
move migration logic
83a13e3
@CyberHoward
formatting [skip ci]
81a16bf
@Kayanski
Revert "Revert "Removed proxy and manager frm std and sdk""
70fd5f5 
This reverts commit 454acd7.
@Kayanski
formatting [skip ci]
9efe4ee
@Kayanski
Execution and replies ok for account contract
75bba18
@Kayanski
Added queries
a078501
@CyberHoward
fix migrate tests
0b4bc5f
@CyberHoward
instantiate test
df4d8a4
@CyberHoward
Merge remote-tracking branch 'origin/develop/v2' into robin/abs-504-a…
c813ca7 
…ccount-self-registration-2
@CyberHoward CyberHoward changed the base branch from main to develop/v2 September 10, 2024 11:47
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 10, 2024 •
edited
Loading

Deploying abstract-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9864f14
Status:⚡️  Build in progress...

View logs

Kayanski
Kayanski requested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@Kayanski Kayanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice ! A little change on the creator parameter that seems useless

framework/contracts/account/account/src/contract.rs Outdated Show resolved Hide resolved
framework/contracts/native/version-control/src/commands.rs Show resolved Hide resolved
Buckram123
Buckram123 reviewed Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Should we decrease amount of checks for account registration, or is it helping user during account creation?

framework/contracts/account/account/Cargo.toml Outdated Show resolved Hide resolved
framework/contracts/native/version-control/src/commands.rs Show resolved Hide resolved
framework/contracts/native/version-control/src/commands.rs Outdated Show resolved Hide resolved
framework/packages/abstract-testing/src/lib.rs Outdated Show resolved Hide resolved
framework/contracts/native/version-control/src/commands.rs Show resolved Hide resolved
@CyberHoward CyberHoward marked this pull request as ready for review September 12, 2024 08:40
@CyberHoward
Copy link
Contributor Author

Merge #444 First!!

@CyberHoward CyberHoward merged commit eb2faeb into develop/v2 Sep 12, 2024
4 of 12 checks passed
@CyberHoward CyberHoward deleted the robin/abs-504-account-self-registration-2 branch September 12, 2024 13:27
@Buckram123 Buckram123 mentioned this pull request Sep 15, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Buckram123 Buckram123 Buckram123 left review comments

@Kayanski Kayanski Kayanski requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CyberHoward @Kayanski @Buckram123