-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix abstract-interface, abstract-client, abstract-testing #456
Merged
CyberHoward
merged 14 commits into
develop/v2
from
fix/abstract-interface_abstract-client_abstract-testing
Sep 16, 2024
Merged
Fix abstract-interface, abstract-client, abstract-testing #456
CyberHoward
merged 14 commits into
develop/v2
from
fix/abstract-interface_abstract-client_abstract-testing
Sep 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying abstract-docs with Cloudflare Pages
|
CyberHoward
reviewed
Sep 16, 2024
CyberHoward
reviewed
Sep 16, 2024
CyberHoward
reviewed
Sep 16, 2024
CyberHoward
reviewed
Sep 16, 2024
…terface_abstract-client_abstract-testing
CyberHoward
reviewed
Sep 16, 2024
framework/packages/abstract-testing/src/abstract_mock_querier.rs
Outdated
Show resolved
Hide resolved
CyberHoward
reviewed
Sep 16, 2024
CyberHoward
reviewed
Sep 16, 2024
…terface_abstract-client_abstract-testing
CyberHoward
reviewed
Sep 16, 2024
CyberHoward
requested changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nits
CyberHoward
approved these changes
Sep 16, 2024
CyberHoward
deleted the
fix/abstract-interface_abstract-client_abstract-testing
branch
September 16, 2024 14:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix packages mentioned in a title.
@CyberHoward noticed you changed in #446
TEST_ACCOUNT_ID
toABSTRACT_ACCOUNT_ID
as saved account inmock_querier_builder
for abstract-testing. Was that mistake? Should it contain both, or test account have to be created in every test?Checklist