Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix abstract-interface, abstract-client, abstract-testing #456

Merged

Conversation

Buckram123
Copy link
Collaborator

This PR aims to fix packages mentioned in a title.

@CyberHoward noticed you changed in #446 TEST_ACCOUNT_ID to ABSTRACT_ACCOUNT_ID as saved account in mock_querier_builder for abstract-testing. Was that mistake? Should it contain both, or test account have to be created in every test?

Checklist

  • CI is green.
  • Changelog updated.

Copy link

cloudflare-workers-and-pages bot commented Sep 16, 2024

Deploying abstract-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: d3950e6
Status: ✅  Deploy successful!
Preview URL: https://c0b574a3.abstract-docs.pages.dev
Branch Preview URL: https://fix-abstract-interface-abstr.abstract-docs.pages.dev

View logs

@Buckram123 Buckram123 marked this pull request as ready for review September 16, 2024 13:06
Copy link
Contributor

@CyberHoward CyberHoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits

framework/packages/abstract-testing/src/mock_querier.rs Outdated Show resolved Hide resolved
framework/packages/abstract-testing/src/mock_querier.rs Outdated Show resolved Hide resolved
Co-authored-by: cyberhoward <cyberhoward@protonmail.com>
@CyberHoward CyberHoward merged commit fab33e7 into develop/v2 Sep 16, 2024
6 of 13 checks passed
@CyberHoward CyberHoward deleted the fix/abstract-interface_abstract-client_abstract-testing branch September 16, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants